[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/6] block/block-backend: remove always true check from blk_save_
From: |
Denis V. Lunev |
Subject: |
[PATCH 4/6] block/block-backend: remove always true check from blk_save_vmstate |
Date: |
Fri, 19 Jun 2020 13:07:06 +0300 |
bdrv_save_vmstate() returns either error with negative return value or
size. Thus this check is useless.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Suggested-by: Eric Blake <eblake@redhat.com>
CC: Kevin Wolf <kwolf@redhat.com>
CC: Max Reitz <mreitz@redhat.com>
CC: Stefan Hajnoczi <stefanha@redhat.com>
CC: Fam Zheng <fam@euphon.net>
CC: Juan Quintela <quintela@redhat.com>
CC: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
CC: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
CC: Denis Plotnikov <dplotnikov@virtuozzo.com>
---
block/block-backend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/block-backend.c b/block/block-backend.c
index 6936b25c83..1c6e53bbde 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -2188,7 +2188,7 @@ int blk_save_vmstate(BlockBackend *blk, const uint8_t
*buf,
return ret;
}
- if (ret == size && !blk->enable_write_cache) {
+ if (!blk->enable_write_cache) {
ret = bdrv_flush(blk_bs(blk));
}
--
2.17.1
- [PATCH v5 0/6] block: seriously improve savevm performance, Denis V. Lunev, 2020/06/19
- [PATCH 4/6] block/block-backend: remove always true check from blk_save_vmstate,
Denis V. Lunev <=
- [PATCH 3/6] block/aio_task: drop aio_task_pool_wait_one() helper, Denis V. Lunev, 2020/06/19
- [PATCH 2/6] block/aio_task: allow start/wait task from any coroutine, Denis V. Lunev, 2020/06/19
- [PATCH 1/6] migration/savevm: respect qemu_fclose() error code in save_snapshot(), Denis V. Lunev, 2020/06/19
- [PATCH 6/6] block/io: improve savevm performance, Denis V. Lunev, 2020/06/19
- [PATCH 5/6] block, migration: add bdrv_finalize_vmstate helper, Denis V. Lunev, 2020/06/19
- Re: [PATCH v5 0/6] block: seriously improve savevm performance, no-reply, 2020/06/19
- [PATCH 7/6] block/io: improve loadvm performance, Denis V. Lunev, 2020/06/22