[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/7] audio/jack: remove invalid set of input support bool
From: |
Gerd Hoffmann |
Subject: |
[PULL 3/7] audio/jack: remove invalid set of input support bool |
Date: |
Fri, 19 Jun 2020 15:17:37 +0200 |
From: Geoffrey McRae <geoff@hostfission.com>
Initial code for JACK did not support audio input and as such this
boolean was set to let QEMU know, however JACK ended up including input
support making this invalid. Further investigation shows it was invalid
to set it in the first instance anyway due to a failure on my part
understand properly what this was for when the audodev was initially
developed.
Signed-off-by: Geoffrey McRae <geoff@hostfission.com>
Message-id: 20200613040518.38172-4-geoff@hostfission.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
audio/jackaudio.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index fb8efd7af7c7..58c73444977e 100644
--- a/audio/jackaudio.c
+++ b/audio/jackaudio.c
@@ -607,9 +607,6 @@ static int qjack_thread_creator(jack_native_thread_t
*thread,
static void *qjack_init(Audiodev *dev)
{
assert(dev->driver == AUDIODEV_DRIVER_JACK);
-
- dev->u.jack.has_in = false;
-
return dev;
}
--
2.18.4
- [PULL 0/7] Audio 20200619 patches, Gerd Hoffmann, 2020/06/19
- [PULL 3/7] audio/jack: remove invalid set of input support bool,
Gerd Hoffmann <=
- [PULL 4/7] audio/jack: do not remove ports when finishing, Gerd Hoffmann, 2020/06/19
- [PULL 6/7] audio/jack: simplify the re-init code path, Gerd Hoffmann, 2020/06/19
- [PULL 2/7] audio/jack: remove unused stopped state, Gerd Hoffmann, 2020/06/19
- [PULL 1/7] audio/jack: fix invalid minimum buffer size check, Gerd Hoffmann, 2020/06/19
- [PULL 7/7] hw/audio/gus: Fix registers 32-bit access, Gerd Hoffmann, 2020/06/19
- [PULL 5/7] audio/jack: honour the enable state of the audio device, Gerd Hoffmann, 2020/06/19
- Re: [PULL 0/7] Audio 20200619 patches, no-reply, 2020/06/19
- Re: [PULL 0/7] Audio 20200619 patches, no-reply, 2020/06/19
- Re: [PULL 0/7] Audio 20200619 patches, Peter Maydell, 2020/06/22