[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 5/9] sm501: Optimise 1 pixel 2d ops
From: |
BALATON Zoltan |
Subject: |
[PATCH v3 5/9] sm501: Optimise 1 pixel 2d ops |
Date: |
Sat, 20 Jun 2020 22:56:28 +0200 |
Some guests do 1x1 blits which is faster to do directly than calling a
function for it so avoid overhead in this case.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/display/sm501.c | 19 ++++++++++++++++---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 3ced2c42db..2098e69810 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -794,6 +794,14 @@ static void sm501_2d_operation(SM501State *s)
src_x == dst_x && src_y == dst_y) {
break;
}
+ /* Some clients also do 1 pixel blits, avoid overhead for these */
+ if (width == 1 && height == 1) {
+ unsigned int si = (src_x + src_y * src_pitch) * bypp;
+ unsigned int di = (dst_x + dst_y * dst_pitch) * bypp;
+ stn_he_p(&s->local_mem[dst_base + di], bypp,
+ ldn_he_p(&s->local_mem[src_base + si], bypp));
+ break;
+ }
/* Check for overlaps, this could be made more exact */
uint32_t sb, se, db, de;
sb = src_base + src_x + src_y * (width + src_pitch);
@@ -842,9 +850,14 @@ static void sm501_2d_operation(SM501State *s)
color = cpu_to_le16(color);
}
- pixman_fill((uint32_t *)&s->local_mem[dst_base],
- dst_pitch * bypp / sizeof(uint32_t),
- 8 * bypp, dst_x, dst_y, width, height, color);
+ if (width == 1 && height == 1) {
+ unsigned int i = (dst_x + dst_y * dst_pitch) * bypp;
+ stn_he_p(&s->local_mem[dst_base + i], bypp, color);
+ } else {
+ pixman_fill((uint32_t *)&s->local_mem[dst_base],
+ dst_pitch * bypp / sizeof(uint32_t),
+ 8 * bypp, dst_x, dst_y, width, height, color);
+ }
break;
}
default:
--
2.21.3
- [PATCH v3 0/9] More sm501 fixes and optimisations, BALATON Zoltan, 2020/06/20
- [PATCH v3 5/9] sm501: Optimise 1 pixel 2d ops,
BALATON Zoltan <=
- [PATCH v3 4/9] sm501: Introduce variable for commonly used value for better readability, BALATON Zoltan, 2020/06/20
- [PATCH v3 6/9] sm501: Use stn_he_p/ldn_he_p instead of switch/case, BALATON Zoltan, 2020/06/20
- [PATCH v3 1/9] sm501: Fix bounds checks, BALATON Zoltan, 2020/06/20
- [PATCH v3 7/9] sm501: Do not allow guest to set invalid format, BALATON Zoltan, 2020/06/20
- [PATCH v3 3/9] sm501: Ignore no-op blits, BALATON Zoltan, 2020/06/20
- [PATCH v3 9/9] sm501: Fix and optimize overlap check, BALATON Zoltan, 2020/06/20