[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 2/9] sm501: Drop unneded variable
From: |
BALATON Zoltan |
Subject: |
[PATCH v3 2/9] sm501: Drop unneded variable |
Date: |
Sat, 20 Jun 2020 22:56:28 +0200 |
We don't need a separate variable to keep track if we allocated memory
that needs to be freed as we can test the pointer itself.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/display/sm501.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 5ceee4166f..5d2e019575 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -796,13 +796,12 @@ static void sm501_2d_operation(SM501State *s)
de = db + width + height * (width + dst_pitch);
if (rtl && ((db >= sb && db <= se) || (de >= sb && de <= se))) {
/* regions may overlap: copy via temporary */
- int free_buf = 0, llb = width * (1 << format);
+ int llb = width * (1 << format);
int tmp_stride = DIV_ROUND_UP(llb, sizeof(uint32_t));
uint32_t *tmp = tmp_buf;
if (tmp_stride * sizeof(uint32_t) * height > sizeof(tmp_buf)) {
tmp = g_malloc(tmp_stride * sizeof(uint32_t) * height);
- free_buf = 1;
}
pixman_blt((uint32_t *)&s->local_mem[src_base], tmp,
src_pitch * (1 << format) / sizeof(uint32_t),
@@ -813,7 +812,7 @@ static void sm501_2d_operation(SM501State *s)
dst_pitch * (1 << format) / sizeof(uint32_t),
8 * (1 << format), 8 * (1 << format),
0, 0, dst_x, dst_y, width, height);
- if (free_buf) {
+ if (tmp != tmp_buf) {
g_free(tmp);
}
} else {
--
2.21.3
- [PATCH v3 6/9] sm501: Use stn_he_p/ldn_he_p instead of switch/case, (continued)
- [PATCH v3 6/9] sm501: Use stn_he_p/ldn_he_p instead of switch/case, BALATON Zoltan, 2020/06/20
- [PATCH v3 1/9] sm501: Fix bounds checks, BALATON Zoltan, 2020/06/20
- [PATCH v3 7/9] sm501: Do not allow guest to set invalid format, BALATON Zoltan, 2020/06/20
- [PATCH v3 3/9] sm501: Ignore no-op blits, BALATON Zoltan, 2020/06/20
- [PATCH v3 9/9] sm501: Fix and optimize overlap check, BALATON Zoltan, 2020/06/20
- [PATCH v3 2/9] sm501: Drop unneded variable,
BALATON Zoltan <=
- [PATCH v3 8/9] sm501: Convert debug printfs to traces, BALATON Zoltan, 2020/06/20