qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] qga: Use gethostname() instead of g_get_host_name()


From: Michal Privoznik
Subject: Re: [PATCH] qga: Use gethostname() instead of g_get_host_name()
Date: Mon, 22 Jun 2020 12:06:17 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0

On 6/19/20 11:54 PM, Richard Henderson wrote:
On 6/16/20 1:34 AM, Michal Privoznik wrote:
+#ifndef G_OS_WIN32

Nit: positive tests are easier to reason with and extend than negative tests.
I would reverse these two blocks and use a positive test for windows.

Also, CONFIG_WIN32 is what we use elsewhere for this test.


r~


Fair enough. Do you want me to send v2 or is it something that committer can fix before merging?

Michal




reply via email to

[Prev in Thread] Current Thread [Next in Thread]