[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/18] block/block-copy: block_copy_dirty_clusters: fix failure ch
From: |
Max Reitz |
Subject: |
[PULL 03/18] block/block-copy: block_copy_dirty_clusters: fix failure check |
Date: |
Mon, 22 Jun 2020 17:10:44 +0200 |
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
ret may be > 0 on success path at this point. Fix assertion, which may
crash currently.
Fixes: 4ce5dd3e9b5ee0fac18625860eb3727399ee965e
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200526181347.489557-1-vsementsov@virtuozzo.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
block/block-copy.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/block-copy.c b/block/block-copy.c
index bb8d0569f2..f7428a7c08 100644
--- a/block/block-copy.c
+++ b/block/block-copy.c
@@ -622,8 +622,10 @@ out:
* block_copy_task_run. If it fails, it means some task already failed
* for real reason, let's return first failure.
* Still, assert that we don't rewrite failure by success.
+ *
+ * Note: ret may be positive here because of block-status result.
*/
- assert(ret == 0 || aio_task_pool_status(aio) < 0);
+ assert(ret >= 0 || aio_task_pool_status(aio) < 0);
ret = aio_task_pool_status(aio);
aio_task_pool_free(aio);
--
2.26.2
- [PULL 00/18] Block patches, Max Reitz, 2020/06/22
- [PULL 01/18] iotests: Make _filter_img_create more active, Max Reitz, 2020/06/22
- [PULL 03/18] block/block-copy: block_copy_dirty_clusters: fix failure check,
Max Reitz <=
- [PULL 07/18] block/amend: separate amend and create options for qemu-img, Max Reitz, 2020/06/22
- [PULL 10/18] block/crypto: implement the encryption key management, Max Reitz, 2020/06/22
- [PULL 02/18] iotests: filter few more luks specific create options, Max Reitz, 2020/06/22
- [PULL 09/18] block/crypto: rename two functions, Max Reitz, 2020/06/22
- [PULL 05/18] qcrypto/luks: implement encryption key management, Max Reitz, 2020/06/22
- [PULL 06/18] block/amend: add 'force' option, Max Reitz, 2020/06/22
- [PULL 04/18] qcrypto/core: add generic infrastructure for crypto options amendment, Max Reitz, 2020/06/22
- [PULL 08/18] block/amend: refactor qcow2 amend options, Max Reitz, 2020/06/22
- [PULL 11/18] block/qcow2: extend qemu-img amend interface with crypto options, Max Reitz, 2020/06/22
- [PULL 14/18] block/crypto: implement blockdev-amend, Max Reitz, 2020/06/22