[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 5/9] hw/misc/pca9552: Add a 'description' property for debuggi
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v5 5/9] hw/misc/pca9552: Add a 'description' property for debugging purpose |
Date: |
Mon, 22 Jun 2020 20:34:24 +0200 |
Add a description field to distinguish between multiple devices.
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
include/hw/misc/pca9552.h | 1 +
hw/misc/pca9552.c | 11 +++++++++++
2 files changed, 12 insertions(+)
diff --git a/include/hw/misc/pca9552.h b/include/hw/misc/pca9552.h
index 90843b03b8..bf1a589137 100644
--- a/include/hw/misc/pca9552.h
+++ b/include/hw/misc/pca9552.h
@@ -27,6 +27,7 @@ typedef struct PCA955xState {
uint8_t pointer;
uint8_t regs[PCA955X_NR_REGS];
+ char *description; /* For debugging purpose only */
} PCA955xState;
#endif
diff --git a/hw/misc/pca9552.c b/hw/misc/pca9552.c
index 34062dbb69..d6d84c6451 100644
--- a/hw/misc/pca9552.c
+++ b/hw/misc/pca9552.c
@@ -13,6 +13,7 @@
#include "qemu/osdep.h"
#include "qemu/log.h"
#include "qemu/module.h"
+#include "hw/qdev-properties.h"
#include "hw/misc/pca9552.h"
#include "hw/misc/pca9552_regs.h"
#include "migration/vmstate.h"
@@ -319,10 +320,19 @@ static void pca955x_initfn(Object *obj)
static void pca955x_realize(DeviceState *dev, Error **errp)
{
PCA955xClass *k = PCA955X_GET_CLASS(dev);
+ PCA955xState *s = PCA955X(dev);
assert(k->pin_count <= PCA955X_PIN_COUNT_MAX);
+ if (!s->description) {
+ s->description = g_strdup("pca-unspecified");
+ }
}
+static Property pca955x_properties[] = {
+ DEFINE_PROP_STRING("description", PCA955xState, description),
+ DEFINE_PROP_END_OF_LIST(),
+};
+
static void pca955x_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
@@ -332,6 +342,7 @@ static void pca955x_class_init(ObjectClass *klass, void
*data)
k->recv = pca955x_recv;
k->send = pca955x_send;
dc->realize = pca955x_realize;
+ device_class_set_props(dc, pca955x_properties);
}
static const TypeInfo pca955x_info = {
--
2.21.3
- [PATCH v5 1/9] hw/i2c/core: Add i2c_try_create_slave() and i2c_realize_and_unref(), (continued)
- [PATCH v5 1/9] hw/i2c/core: Add i2c_try_create_slave() and i2c_realize_and_unref(), Philippe Mathieu-Daudé, 2020/06/22
- [PATCH v5 2/9] hw/misc/pca9552: Rename 'nr_leds' as 'pin_count', Philippe Mathieu-Daudé, 2020/06/22
- [PATCH v5 3/9] hw/misc/pca9552: Rename generic code as pca955x, Philippe Mathieu-Daudé, 2020/06/22
- [PATCH v5 4/9] hw/misc/pca9552: Add generic PCA955xClass, parent of TYPE_PCA9552, Philippe Mathieu-Daudé, 2020/06/22
- [PATCH v5 5/9] hw/misc/pca9552: Add a 'description' property for debugging purpose,
Philippe Mathieu-Daudé <=
- [PATCH v5 6/9] hw/misc/pca9552: Trace GPIO High/Low events, Philippe Mathieu-Daudé, 2020/06/22
- [PATCH v5 7/9] hw/arm/aspeed: Describe each PCA9552 device, Philippe Mathieu-Daudé, 2020/06/22
- [PATCH v5 8/9] hw/misc/pca9552: Trace GPIO change events, Philippe Mathieu-Daudé, 2020/06/22
- [PATCH v5 9/9] hw/misc/pca9552: Model qdev output GPIOs, Philippe Mathieu-Daudé, 2020/06/22