[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH QEMU v25 06/17] vfio: Add migration state change notifier
From: |
Cornelia Huck |
Subject: |
Re: [PATCH QEMU v25 06/17] vfio: Add migration state change notifier |
Date: |
Tue, 23 Jun 2020 10:10:26 +0200 |
On Sun, 21 Jun 2020 01:51:15 +0530
Kirti Wankhede <kwankhede@nvidia.com> wrote:
> Added migration state change notifier to get notification on migration state
> change. These states are translated to VFIO device state and conveyed to
> vendor
> driver.
>
> Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com>
> Reviewed-by: Neo Jia <cjia@nvidia.com>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hw/vfio/migration.c | 29 +++++++++++++++++++++++++++++
> hw/vfio/trace-events | 5 +++--
> include/hw/vfio/vfio-common.h | 1 +
> 3 files changed, 33 insertions(+), 2 deletions(-)
>
> diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
> index fcecc0bb0874..e30bd8768701 100644
> --- a/hw/vfio/migration.c
> +++ b/hw/vfio/migration.c
> @@ -154,6 +154,28 @@ static void vfio_vmstate_change(void *opaque, int
> running, RunState state)
> }
> }
>
> +static void vfio_migration_state_notifier(Notifier *notifier, void *data)
> +{
> + MigrationState *s = data;
> + VFIODevice *vbasedev = container_of(notifier, VFIODevice,
> migration_state);
> + int ret;
> +
> + trace_vfio_migration_state_notifier(vbasedev->name,
> + MigrationStatus_str(s->state));
> +
> + switch (s->state) {
> + case MIGRATION_STATUS_CANCELLING:
> + case MIGRATION_STATUS_CANCELLED:
> + case MIGRATION_STATUS_FAILED:
> + ret = vfio_migration_set_state(vbasedev,
> + ~(VFIO_DEVICE_STATE_SAVING |
> VFIO_DEVICE_STATE_RESUMING),
> + VFIO_DEVICE_STATE_RUNNING);
> + if (ret) {
> + error_report("%s: Failed to set state RUNNING", vbasedev->name);
Also see
https://lore.kernel.org/qemu-devel/20200505124639.56531df8.cohuck@redhat.com/.
> + }
> + }
> +}
> +
> static int vfio_migration_init(VFIODevice *vbasedev,
> struct vfio_region_info *info)
> {
- Re: [PATCH QEMU v25 03/17] vfio: Add save and load functions for VFIO PCI devices, (continued)
[PATCH QEMU v25 04/17] vfio: Add migration region initialization and finalize function, Kirti Wankhede, 2020/06/20
[PATCH QEMU v25 05/17] vfio: Add VM state change handler to know state of VM, Kirti Wankhede, 2020/06/20
[PATCH QEMU v25 06/17] vfio: Add migration state change notifier, Kirti Wankhede, 2020/06/20
- Re: [PATCH QEMU v25 06/17] vfio: Add migration state change notifier,
Cornelia Huck <=
[PATCH QEMU v25 07/17] vfio: Register SaveVMHandlers for VFIO device, Kirti Wankhede, 2020/06/20
Re: [PATCH QEMU v25 07/17] vfio: Register SaveVMHandlers for VFIO device, Dr. David Alan Gilbert, 2020/06/26
[PATCH QEMU v25 08/17] vfio: Add save state functions to SaveVMHandlers, Kirti Wankhede, 2020/06/20