[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 04/17] linux-user: Tidy VERIFY_READ/VERIFY_WRITE
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2 04/17] linux-user: Tidy VERIFY_READ/VERIFY_WRITE |
Date: |
Thu, 25 Jun 2020 17:29:25 +0100 |
On Fri, 5 Jun 2020 at 05:17, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> These constants are only ever used with access_ok, and friends.
> Rather than translating them to PAGE_* bits, let them equal
> the PAGE_* bits to begin.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Side note: at some point we would ideally want to support
syscalls that checked for write-access-only (ie some of
our VERIFY_WRITE uses should really be VERIFY_READ_WRITE
and some should be a true VERIFY_WRITE):
https://bugs.launchpad.net/qemu/+bug/1779955
thanks
-- PMM
- [PATCH v2 00/17] target-arm: Implement ARMv8.5-MemTag, user mode, Richard Henderson, 2020/06/05
- [PATCH v2 01/17] tcg: Introduce target-specific page data for user-only, Richard Henderson, 2020/06/05
- [PATCH v2 03/17] linux-user: Check for overflow in access_ok, Richard Henderson, 2020/06/05
- [PATCH v2 02/17] linux-user: Introduce PAGE_ANON, Richard Henderson, 2020/06/05
- [PATCH v2 04/17] linux-user: Tidy VERIFY_READ/VERIFY_WRITE, Richard Henderson, 2020/06/05
- Re: [PATCH v2 04/17] linux-user: Tidy VERIFY_READ/VERIFY_WRITE,
Peter Maydell <=
- [PATCH v2 05/17] bsd-user: Tidy VERIFY_READ/VERIFY_WRITE, Richard Henderson, 2020/06/05
- [PATCH v2 06/17] linux-user: Do not use guest_addr_valid for h2g_valid, Richard Henderson, 2020/06/05
- [PATCH v2 07/17] linux-user: Fix guest_addr_valid vs reserved_va, Richard Henderson, 2020/06/05
- [PATCH v2 08/17] exec: Add support for TARGET_TAGGED_ADDRESSES, Richard Henderson, 2020/06/05
- [PATCH v2 09/17] linux-user/aarch64: Implement PR_TAGGED_ADDR_ENABLE, Richard Henderson, 2020/06/05