[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/block/nvme: Align I/O BAR to 4 KiB
From: |
Klaus Jensen |
Subject: |
Re: [PATCH] hw/block/nvme: Align I/O BAR to 4 KiB |
Date: |
Thu, 25 Jun 2020 20:23:26 +0200 |
On Jun 25 17:48, Philippe Mathieu-Daudé wrote:
> Simplify the NVMe emulated device by aligning the I/O BAR to 4 KiB.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> include/block/nvme.h | 3 +++
> hw/block/nvme.c | 5 ++---
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/include/block/nvme.h b/include/block/nvme.h
> index 1720ee1d51..6d87c9c146 100644
> --- a/include/block/nvme.h
> +++ b/include/block/nvme.h
> @@ -22,6 +22,8 @@ typedef struct NvmeBar {
> uint32_t pmrebs;
> uint32_t pmrswtp;
> uint32_t pmrmsc;
> + uint32_t reserved[58];
> + uint8_t cmd_set_specfic[0x100];
> } NvmeBar;
This ends up as a freak mix of v1.3 and v1.4 specs. Since we already
have the PMR stuff in there, I think it makes more sense to align with
v1.4 and remove the reserved bytes.
Otherwise, LGTM.
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>