[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 15/30] tests/docker: change tag naming scheme of our image
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v3 15/30] tests/docker: change tag naming scheme of our images |
Date: |
Mon, 29 Jun 2020 12:04:23 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/26/20 8:13 PM, Alex Bennée wrote:
> We've been misusing the tag naming scheme for some time by overloading
> the post : section with the image type. Really it should be saved for
> the revision of that particular build. Move the details to the other
> side so we have:
>
> qemu/image-name
>
> with the implied :latest version added by the tooling.
>
> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
> ---
> v2
> - fix RUN invocation as well
> - don't include :latest tag for debian-arm64-cross (implied)
> ---
> tests/docker/Makefile.include | 4 ++--
> tests/docker/docker.py | 2 +-
> tests/docker/dockerfiles/debian-alpha-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-amd64-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-amd64.docker | 2 +-
> tests/docker/dockerfiles/debian-arm64-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-arm64-test-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-armel-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-armhf-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-hppa-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-m68k-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-mips-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-mips64-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-mips64el-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-mipsel-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-powerpc-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-ppc64-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-ppc64el-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-riscv64-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-s390x-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-sh4-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-sparc64-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-tricore-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-win32-cross.docker | 2 +-
> tests/docker/dockerfiles/debian-win64-cross.docker | 2 +-
> tests/docker/dockerfiles/debian9-mxe.docker | 2 +-
> 26 files changed, 27 insertions(+), 27 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH v3 14/30] tests/docker: check for an parameters not empty string, (continued)
- [PATCH v3 14/30] tests/docker: check for an parameters not empty string, Alex Bennée, 2020/06/26
- [PATCH v3 20/30] gitlab: convert jobs to use custom built containers, Alex Bennée, 2020/06/26
- [PATCH v3 26/30] gitlab: enable check-tcg for linux-user tests, Alex Bennée, 2020/06/26
- [PATCH v3 15/30] tests/docker: change tag naming scheme of our images, Alex Bennée, 2020/06/26
- Re: [PATCH v3 15/30] tests/docker: change tag naming scheme of our images,
Philippe Mathieu-Daudé <=
- [PATCH v3 19/30] gitlab: build all container images during CI, Alex Bennée, 2020/06/26
- [PATCH v3 23/30] tests/docker: add packages needed for check-acceptance, Alex Bennée, 2020/06/26
- [PATCH v3 28/30] gitlab: split build-disabled into two phases, Alex Bennée, 2020/06/26
- [PATCH v3 29/30] gitlab: limit re-builds of the containers, Alex Bennée, 2020/06/26