Re: [PATCH v1 12/18] tests/vm: allow us to take advantage of MTTCG

[Philippe Mathieu-Daudé]

On 6/29/20 4:41 PM, Alex Bennée wrote:
> 
> Richard Henderson <richard.henderson@linaro.org> writes:
> 
>> On 6/22/20 7:31 AM, Alex Bennée wrote:
>>>          if kvm_available(vmcls.arch):
>>>              return multiprocessing.cpu_count() // 2
>>> +        elif os.uname().machine == "x86_64" and \
>>> +             vmcls.arch in ["aarch64", "x86_64", "i386"]:
>>> +            # MTTCG is available on these arches and we can allow more 
>>> cores.
>>> +            # But only up to a reasonable limit. User can always override
>>> +            # these limits with --jobs.
>>> +            return min(multiprocessing.cpu_count() // 2, 8)
>>>          else:
>>
>> And if multiprocessing.cpu_count() == 1?
>> Seems like we should add max(count, 1) as well.
> 
> As it also affects KVM:
> 
>     def get_default_jobs():
>         if multiprocessing.cpu_count > 1:
>             if kvm_available(vmcls.arch):
>                 return multiprocessing.cpu_count() // 2
>             elif os.uname().machine == "x86_64" and \
>                  vmcls.arch in ["aarch64", "x86_64", "i386"]:
>                 # MTTCG is available on these arches and we can allow more 
> cores.
>                 # But only up to a reasonable limit. User can always override
>                 # these limits with --jobs.
>                 return min(multiprocessing.cpu_count() // 2, 8)
>         else:
>             return 1

For this hunk:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> 
> 
>>
>>
>> r~
> 
>