[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] coverity: provide Coverity-friendly MIN_CONST and MAX_CONST
From: |
no-reply |
Subject: |
Re: [PATCH] coverity: provide Coverity-friendly MIN_CONST and MAX_CONST |
Date: |
Mon, 29 Jun 2020 08:21:45 -0700 (PDT) |
Patchew URL:
20200629151642.11974-1-pbonzini@redhat.com/">https://patchew.org/QEMU/20200629151642.11974-1-pbonzini@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH] coverity: provide Coverity-friendly MIN_CONST and MAX_CONST
Type: series
Message-id: 20200629151642.11974-1-pbonzini@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
* [new tag] patchew/20200629151642.11974-1-pbonzini@redhat.com ->
patchew/20200629151642.11974-1-pbonzini@redhat.com
Switched to a new branch 'test'
3aee0de coverity: provide Coverity-friendly MIN_CONST and MAX_CONST
=== OUTPUT BEGIN ===
WARNING: architecture specific defines should be avoided
#38: FILE: include/qemu/osdep.h:269:
+#ifdef __COVERITY__
ERROR: Macros with complex values should be enclosed in parenthesis
#39: FILE: include/qemu/osdep.h:270:
+#define MIN_CONST(a, b) (a) < (b) ? (a) : (b)
ERROR: Macros with complex values should be enclosed in parenthesis
#40: FILE: include/qemu/osdep.h:271:
+#define MAX_CONST(a, b) (a) > (b) ? (a) : (b)
total: 2 errors, 1 warnings, 34 lines checked
Commit 3aee0de30ad2 (coverity: provide Coverity-friendly MIN_CONST and
MAX_CONST) has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
20200629151642.11974-1-pbonzini@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200629151642.11974-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com