[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 01/12] pc-bios: s390x: cio.c cleanup and compile fix
From: |
Cornelia Huck |
Subject: |
Re: [PATCH v5 01/12] pc-bios: s390x: cio.c cleanup and compile fix |
Date: |
Mon, 29 Jun 2020 17:50:19 +0200 |
On Wed, 24 Jun 2020 03:52:15 -0400
Janosch Frank <frankja@linux.ibm.com> wrote:
> Let's initialize the structs at the beginning to ease reading and also
> zeroing all other fields. This also makes the compiler stop
> complaining about sense_id_ccw.flags being ored into when it's not
> initialized.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: David Hildenbrand <david@redhat.com>
> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> pc-bios/s390-ccw/cio.c | 40 ++++++++++++++++++++++------------------
> 1 file changed, 22 insertions(+), 18 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
- [PATCH v5 00/12] pc-bios: s390x: Cleanup part 1, Janosch Frank, 2020/06/24
- [PATCH v5 03/12] pc-bios: s390x: Move sleep and yield to helper.h, Janosch Frank, 2020/06/24
- [PATCH v5 02/12] pc-bios: s390x: Consolidate timing functions into time.h, Janosch Frank, 2020/06/24
- [PATCH v5 01/12] pc-bios: s390x: cio.c cleanup and compile fix, Janosch Frank, 2020/06/24
- Re: [PATCH v5 01/12] pc-bios: s390x: cio.c cleanup and compile fix,
Cornelia Huck <=
- [PATCH v5 07/12] pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR, Janosch Frank, 2020/06/24
- [PATCH v5 06/12] pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64, Janosch Frank, 2020/06/24
- [PATCH v5 11/12] pc-bios: s390x: Fix bootmap.c passing PSWs as addresses, Janosch Frank, 2020/06/24
- [PATCH v5 05/12] pc-bios: s390x: Remove unneeded dasd-ipl.c reset psw mask changes, Janosch Frank, 2020/06/24