[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 11/26] vnc: Plug minor memory leak in vnc_display_open()
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH v3 11/26] vnc: Plug minor memory leak in vnc_display_open() |
|
Date: |
Tue, 30 Jun 2020 10:19:52 +0100 |
|
User-agent: |
Mutt/1.14.3 (2020-06-14) |
On Tue, Jun 30, 2020 at 11:03:36AM +0200, Markus Armbruster wrote:
> vnc_display_print_local_addr() leaks the Error object when
> qio_channel_socket_get_local_address() fails. Seems unlikely. Called
> when we create a VNC display with vnc_display_open(). Plug the leak
> by passing NULL to ignore the error.
>
> Cc: Daniel P. Berrange <berrange@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> ui/vnc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH v3 26/26] migration/rdma: Plug memory leaks in qemu_rdma_registration_stop(), (continued)
- [PATCH v3 16/26] hw/arm: Drop useless object_property_set_link() error handling, Markus Armbruster, 2020/06/30
- [PATCH v3 24/26] hw/arm/armsse: Fix armsse_realize() error API violation, Markus Armbruster, 2020/06/30
- [PATCH v3 17/26] riscv/sifive_u: Fix sifive_u_soc_realize() error API violations, Markus Armbruster, 2020/06/30
- [PATCH v3 19/26] mips/cps: Fix mips_cps_realize() error API violations, Markus Armbruster, 2020/06/30
- [PATCH v3 18/26] riscv_hart: Fix riscv_harts_realize() error API violations, Markus Armbruster, 2020/06/30
- [PATCH v3 25/26] arm/{bcm2835, fsl-imx25, fsl-imx6}: Fix realize error API violations, Markus Armbruster, 2020/06/30
- [PATCH v3 11/26] vnc: Plug minor memory leak in vnc_display_open(), Markus Armbruster, 2020/06/30
- Re: [PATCH v3 11/26] vnc: Plug minor memory leak in vnc_display_open(),
Daniel P . Berrangé <=
- [PATCH v3 02/26] pci: Delete useless error_propagate(), Markus Armbruster, 2020/06/30
- [PATCH v3 15/26] hw: Fix error API violation around object_property_set_link(), Markus Armbruster, 2020/06/30
- [PATCH v3 21/26] amd_iommu: Fix amdvi_realize() error API violation, Markus Armbruster, 2020/06/30
- [PATCH v3 23/26] aspeed: Fix realize error API violation, Markus Armbruster, 2020/06/30
- [PATCH v3 01/26] net/virtio: Fix failover_replug_primary() return value regression, Markus Armbruster, 2020/06/30