[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 5/9] nvram: add nrf51_soc flash read method
From: |
P J P |
Subject: |
[PATCH v3 5/9] nvram: add nrf51_soc flash read method |
Date: |
Tue, 30 Jun 2020 17:57:06 +0530 |
From: Prasad J Pandit <pjp@fedoraproject.org>
Add nrf51_soc mmio read method to avoid NULL pointer dereference
issue.
Reported-by: Lei Sun <slei.casper@gmail.com>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
hw/nvram/nrf51_nvm.c | 5 +++++
1 file changed, 5 insertions(+)
Update v3: use g_assert_not_reached()
-> https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg09560.html
diff --git a/hw/nvram/nrf51_nvm.c b/hw/nvram/nrf51_nvm.c
index f2283c1a8d..82e89d965b 100644
--- a/hw/nvram/nrf51_nvm.c
+++ b/hw/nvram/nrf51_nvm.c
@@ -273,6 +273,10 @@ static const MemoryRegionOps io_ops = {
.endianness = DEVICE_LITTLE_ENDIAN,
};
+static uint64_t flash_read(void *opaque, hwaddr offset, unsigned size)
+{
+ g_assert_not_reached();
+}
static void flash_write(void *opaque, hwaddr offset, uint64_t value,
unsigned int size)
@@ -300,6 +304,7 @@ static void flash_write(void *opaque, hwaddr offset,
uint64_t value,
static const MemoryRegionOps flash_ops = {
+ .read = flash_read,
.write = flash_write,
.valid.min_access_size = 4,
.valid.max_access_size = 4,
--
2.26.2
- [PATCH v3 0/9] memory: assert and define MemoryRegionOps callbacks, P J P, 2020/06/30
- [PATCH v3 1/9] hw/pci-host: add pci-intack write method, P J P, 2020/06/30
- [PATCH v3 2/9] pci-host: add pcie-msi read method, P J P, 2020/06/30
- [PATCH v3 3/9] vfio: add quirk device write method, P J P, 2020/06/30
- [PATCH v3 4/9] prep: add ppc-parity write method, P J P, 2020/06/30
- [PATCH v3 5/9] nvram: add nrf51_soc flash read method,
P J P <=
- [PATCH v3 6/9] spapr_pci: add spapr msi read method, P J P, 2020/06/30
- [PATCH v3 7/9] tz-ppc: add dummy read/write methods, P J P, 2020/06/30
- [PATCH v3 8/9] imx7-ccm: add digprog mmio write method, P J P, 2020/06/30
- [PATCH v3 9/9] memory: assert MemoryRegionOps callbacks are defined, P J P, 2020/06/30
- Re: [PATCH v3 0/9] memory: assert and define MemoryRegionOps callbacks, no-reply, 2020/06/30