[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Revert "tests/migration: Reduce autoconverge initial bandwid
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] Revert "tests/migration: Reduce autoconverge initial bandwidth" |
Date: |
Tue, 30 Jun 2020 16:55:34 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/23/20 4:56 PM, Michael S. Tsirkin wrote:
> This reverts commit 6d1da867e65f ("tests/migration: Reduce autoconverge
> initial bandwidth")
> since that change makes unit tests much slower for all developers, while it's
> not
> a robust way to fix migration tests. Migration tests need to find
> a more robust way to discover a reasonable bandwidth without slowing
> things down for everyone.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> ---
> tests/qtest/migration-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index dc3490c9fa..21ea5ba1d2 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)
> * without throttling.
> */
> migrate_set_parameter_int(from, "downtime-limit", 1);
> - migrate_set_parameter_int(from, "max-bandwidth", 1000000); /* ~1Mb/s */
> + migrate_set_parameter_int(from, "max-bandwidth", 100000000); /* ~100Mb/s
> */
>
> /* To check remaining size after precopy */
> migrate_set_capability(from, "pause-before-switchover", true);
>
Acked-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- Re: [PATCH] Revert "tests/migration: Reduce autoconverge initial bandwidth", (continued)
Re: [PATCH] Revert "tests/migration: Reduce autoconverge initial bandwidth",
Philippe Mathieu-Daudé <=