[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matchi
From: |
Richard Henderson |
Subject: |
Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware |
Date: |
Tue, 30 Jun 2020 13:36:38 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/30/20 10:28 AM, Aleksandar Markovic wrote:
> уто, 30. јун 2020. у 19:16 Philippe Mathieu-Daudé <f4bug@amsat.org> је
> написао/ла:
>>
>> On 6/30/20 6:55 PM, Aleksandar Markovic wrote:
>>> уто, 30. јун 2020. у 18:46 Philippe Mathieu-Daudé <f4bug@amsat.org> је
>>> написао/ла:
>>>>
>>>> On 6/30/20 5:38 PM, Aleksandar Markovic wrote:
>>>>> уто, 30. јун 2020. у 16:52 Philippe Mathieu-Daudé <f4bug@amsat.org> је
>>>>> написао/ла:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> This series add a new 'malta-strict' machine, that aims to properly
>>>>>> model the real hardware (which is not what the current 'malta'
>>>>>> machine models).
>>>>>>
>>>>>> As a bonus for Debian builders, a 'malta-unleashed' machine RFC
>>>>>> patch is included. This might start another endless discussion
>>>>>> upstream, but this is not the point of, so I still include it
>>>>>> for people to test. The rest of the series is candidate for merging
>>>>>> in mainstream QEMU.
>>>>>>
>>>>>> Philippe Mathieu-Daudé (6):
>>>>>> hw/mips/malta: Trivial code movement
>>>>>> hw/mips/malta: Register the machine as a TypeInfo
>>>>>> hw/mips/malta: Introduce MaltaMachineClass::max_ramsize
>>>>>> hw/mips/malta: Introduce the 'malta-strict' machine
>>>>>> hw/mips/malta: Verify malta-strict machine uses correct DIMM sizes
>>>>>> hw/mips/malta: Introduce the 'malta-unleashed' 64-bit machine
>>>>>>
>>>>>> hw/mips/malta.c | 125 ++++++++++++++++++++++++++++++++++++++++++------
>>>>>> 1 file changed, 111 insertions(+), 14 deletions(-)
>>>>>>
>>>>>> --
>>>>>
>>>>> This whole series is based on idea of emulating physically
>>>>> non-existing feature, and as such violates the fundamental principles
>>>>> of QEMU.
>>>>>
>>>>> As such, not acceptable for upstreaming.
>>>>>
>>>>> I don't see the point of sending again the same series, in just
>>>>> cosmetically different form, if it was said to you that the concept is
>>>>> wrong.
>>>>
>>>> Have you looked at the patches? What "violates the fundamental
>>>> principles of QEMU" is the code currently in mainstream. Should
>>>> we remove it? I can send a patch for it if it pleases you, but
>>>> you will make QEMU unuseful for many distribution users.
>>>>
>>>
>>> Past mistakes are past mistakes. We have to live with them. And not
>>> make them in the future.
>>>
>>> I see the whole series as a precursor for your change that repeats
>>> past mistakes, a "wolf in sheep clothing".
>>>
>>> That's why I reject the series as a whole.
>>
>> As a co-maintainer I don't accept that.
>>
>
> I offered you the full maintainership for Malta.
>
> You said you can proveide only "Odd fiexes".
>
> I had to jump in to provide "Maintained" status.
>
> Therefore, I provide the higher level of maintainership, and you have
> to respect that. But you don't.
You need to cool your jets here, Aleksandar.
You do not have some mythical "higher level" of maintainership. Nor, as far as
I can tell, are you actually doing anything with Malta whereas Philippe is.
r~
- Re: [PATCH v2 3/6] hw/mips/malta: Introduce MaltaMachineClass::max_ramsize, (continued)
- [PATCH v2 4/6] hw/mips/malta: Introduce the 'malta-strict' machine, Philippe Mathieu-Daudé, 2020/06/30
- [PATCH v2 5/6] hw/mips/malta: Verify malta-strict machine uses correct DIMM sizes, Philippe Mathieu-Daudé, 2020/06/30
- [PATCH v2 6/6] hw/mips/malta: Introduce the 'malta-unleashed' 64-bit machine, Philippe Mathieu-Daudé, 2020/06/30
- Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware, Aleksandar Markovic, 2020/06/30
- Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware, Philippe Mathieu-Daudé, 2020/06/30
- Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware, Aleksandar Markovic, 2020/06/30
- Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware, Philippe Mathieu-Daudé, 2020/06/30
- Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware, Aleksandar Markovic, 2020/06/30
- Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware, Philippe Mathieu-Daudé, 2020/06/30
- Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware,
Richard Henderson <=
Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware, Thomas Huth, 2020/06/30