Re: [PATCH v3 03/10] target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli()

[Laurent Vivier]

Le 27/08/2020 à 13:03, Chen Qun a écrit :
> Clang static code analyzer show warning:
> target/arm/translate-a64.c:8635:14: warning: Value stored to 'tcg_rn' during 
> its
>  initialization is never read
>     TCGv_i64 tcg_rn = new_tmp_a64(s);
>              ^~~~~~   ~~~~~~~~~~~~~~
> target/arm/translate-a64.c:8636:14: warning: Value stored to 'tcg_rd' during 
> its
>  initialization is never read
>     TCGv_i64 tcg_rd = new_tmp_a64(s);
>              ^~~~~~   ~~~~~~~~~~~~~~
> 
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: qemu-arm@nongnu.org
> 
> v2->v3:According to Peter's review, the variable 's' does not have a memleak,
> so deleted the description about memleak.
> ---
>  target/arm/translate-a64.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
> index 534c3ff5f3..c83bb85e4e 100644
> --- a/target/arm/translate-a64.c
> +++ b/target/arm/translate-a64.c
> @@ -8632,8 +8632,8 @@ static void handle_scalar_simd_shli(DisasContext *s, 
> bool insert,
>      int size = 32 - clz32(immh) - 1;
>      int immhb = immh << 3 | immb;
>      int shift = immhb - (8 << size);
> -    TCGv_i64 tcg_rn = new_tmp_a64(s);
> -    TCGv_i64 tcg_rd = new_tmp_a64(s);
> +    TCGv_i64 tcg_rn;
> +    TCGv_i64 tcg_rd;
>  
>      if (!extract32(immh, 3, 1)) {
>          unallocated_encoding(s);
> 

Applied to my trivial-patches branch.

Thanks,
Laurent