Re: [PATCH 1/2] Makefile: Add back TAGS/ctags/cscope rules

[Paolo Bonzini]

On 01/09/20 16:59, Connor Kuehl wrote:
> On 9/1/20 9:20 AM, Greg Kurz wrote:
>> It is a bit of a pain to be forced to run configure before being able
>> to use cscope and friends. Add back the rules to build them in-tree
>> as before commit a56650518f5b.
>>
>> Fixes: a56650518f5b ("configure: integrate Meson in the build system")
>> Signed-off-by: Greg Kurz <groug@kaod.org>
> 
> This might be a user error on my part, but the way I read this it sounds
> like I could do this:
> 
>     $ rm -rf build
>     $ make cscope
> 
> and have it emit a cscope file,  but when I do so it complains about the
> build dir not existing. As I understand it, running ./configure (or
> meson build) is what generates that build dir. Here's the error for
> posterity:
> 
> changing dir to build for make "cscope"...
> make[1]: *** build: No such file or directory.  Stop.
> make: *** [GNUmakefile:11: cscope] Error 2

You have a stray GNUmakefile in your source directory.  It's not
introduced by Greg's patch.

I suggest that you remove the GNUmakefile and just use out-of-tree builds.

> [...]
> Since this recipe doesn't output an artifact called "cscope" I wonder if
> this should be:
> 
> .PHONY: cscope
> cscope:
>     ...
> 
> or alternatively:
> 
> cscope.out:
>     ...

Yes it should be phony.  I have adjusted the patch and queued it.

Paolo