[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/6] tests: handling signal on win32 properly
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH 5/6] tests: handling signal on win32 properly |
Date: |
Wed, 2 Sep 2020 19:04:51 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 02/09/20 19:00, Yonggang Luo wrote:
> SIGABRT should use signal(SIGABRT, sigabrt_handler) to handle on win32
>
> The error:
> E:/CI-Cor-Ready/xemu/qemu.org/tests/test-replication.c:559:33: error: invalid
> use of undefined type 'struct sigaction'
> 559 | sigact = (struct sigaction) {
> | ^
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
> tests/test-replication.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/test-replication.c b/tests/test-replication.c
> index e0b03dafc2..9ab3666a90 100644
> --- a/tests/test-replication.c
> +++ b/tests/test-replication.c
> @@ -554,6 +554,9 @@ static void sigabrt_handler(int signo)
>
> static void setup_sigabrt_handler(void)
> {
> +#ifdef _WIN32
> + signal(SIGABRT, sigabrt_handler);
> +#else
> struct sigaction sigact;
>
> sigact = (struct sigaction) {
> @@ -562,6 +565,7 @@ static void setup_sigabrt_handler(void)
> };
> sigemptyset(&sigact.sa_mask);
> sigaction(SIGABRT, &sigact, NULL);
> +#endif
> }
>
> int main(int argc, char **argv)
>
This is already fixed by a patch from Thomas.
Paolo
- Re: [PATCH 3/6] ci: Install msys2 in a proper way refer to https://github.com/cirruslabs/cirrus-ci-docs/issues/699 Enable msys2 ci in cirrus, (continued)
- Re: [PATCH 3/6] ci: Install msys2 in a proper way refer to https://github.com/cirruslabs/cirrus-ci-docs/issues/699 Enable msys2 ci in cirrus, Yonggang Luo, 2020/09/02
- Re: [PATCH 3/6] ci: Install msys2 in a proper way refer to https://github.com/cirruslabs/cirrus-ci-docs/issues/699 Enable msys2 ci in cirrus, Yonggang Luo, 2020/09/02
- Re: [PATCH 3/6] ci: Install msys2 in a proper way refer to https://github.com/cirruslabs/cirrus-ci-docs/issues/699 Enable msys2 ci in cirrus, Mark Cave-Ayland, 2020/09/02
- Re: [PATCH 3/6] ci: Install msys2 in a proper way refer to https://github.com/cirruslabs/cirrus-ci-docs/issues/699 Enable msys2 ci in cirrus, Yonggang Luo, 2020/09/02
- Re: [PATCH 3/6] ci: Install msys2 in a proper way refer to https://github.com/cirruslabs/cirrus-ci-docs/issues/699 Enable msys2 ci in cirrus, Mark Cave-Ayland, 2020/09/02
- Re: [PATCH 3/6] ci: Install msys2 in a proper way refer to https://github.com/cirruslabs/cirrus-ci-docs/issues/699 Enable msys2 ci in cirrus, Yonggang Luo, 2020/09/02
- Re: [PATCH 3/6] ci: Install msys2 in a proper way refer to https://github.com/cirruslabs/cirrus-ci-docs/issues/699 Enable msys2 ci in cirrus, Mark Cave-Ayland, 2020/09/02
- Re: [PATCH 3/6] ci: Install msys2 in a proper way refer to https://github.com/cirruslabs/cirrus-ci-docs/issues/699 Enable msys2 ci in cirrus, Yonggang Luo, 2020/09/02
- Re: [PATCH 3/6] ci: Install msys2 in a proper way refer to https://github.com/cirruslabs/cirrus-ci-docs/issues/699 Enable msys2 ci in cirrus, Mark Cave-Ayland, 2020/09/02
[PATCH 5/6] tests: handling signal on win32 properly, Yonggang Luo, 2020/09/02
- Re: [PATCH 5/6] tests: handling signal on win32 properly,
Paolo Bonzini <=
[PATCH 4/6] tcg: Fixes dup_const link error, Yonggang Luo, 2020/09/02
[PATCH 6/6] configure: Fix include and linkage issue on msys2, Yonggang Luo, 2020/09/02