[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL v2 00/76] target/microblaze improvements
|
From: |
Richard Henderson |
|
Subject: |
Re: [PULL v2 00/76] target/microblaze improvements |
|
Date: |
Wed, 2 Sep 2020 16:11:11 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 9/2/20 12:09 PM, Thomas Huth wrote:
> On 01/09/2020 17.20, Richard Henderson wrote:
>> Version 2. Serves me right for not testing 32-bit host
>> when I knew there was a patch that mattered.
>
> Hi Richard,
>
> I'm afraid, but I think this PR broke the
> tests/acceptance/replay_kernel.py:ReplayKernel.test_microblaze_s3adsp1800
> acceptance
> test:
>
> https://gitlab.com/qemu-project/qemu/-/jobs/716158589#L176
>
> Could you please have a look?
That's odd.
Doesn't replay rely on migration (or at least VMStateDescription) to do its
job? Microblaze doesn't implement that, so how could this have worked before?
I admit that I don't often run check-acceptance, because I rarely see a clean
bill of health, even for stuff I'm not working on.
Looking into it...
r~