Re: [PATCH] 9pfs: log warning if msize <= 8192

[Christian Schoenebeck]

On Mittwoch, 2. September 2020 18:54:22 CEST Greg Kurz wrote:
> > Well, I can do that of course. But somehow I fear users get lost by just
> > pointing them to "man 1 qemu" in the log message. It already starts that
> > e.g. on Debian there is no "man qemu", it is "man qemu-system" there
> > instead. Next issue is that qemu man page is currently not structured in
> > a way that would> 
> > allow me to directly point them to the relevant man heading like:
> >     man --pager='less -p ^9P-msize' qemu
> > 
> > So they would need to scroll their way through the entire man page by
> > themselfes and find confusing sections like "-fsdev -device virtio-9p-pci"
> > vs. "-virtfs", etc. I can imagine some people will struggle with that.
> > 
> > With a link like "https://wiki.qemu.org/Documentation/9psetup#msize"; the
> > thing would be crystal clear within seconds.
> > 
> > Just my opinion. Greg?
> 
> Fine by me for this patch.
> 
> For a longer term, maybe we should find a way to advertise some hint
> for msize to the guest... Not sure how to do that though.

On the long term that would be possible, however only with a protocol change 
allowing server to send minimum, maximum and recommended msize to client.

As you know, right now server only has a say in maximum msize.

Best regards,
Christian Schoenebeck