Re: [PATCH v3 00/12] Green the msys2 CI make

[Daniel P . Berrangé]

On Thu, Sep 03, 2020 at 03:43:01PM +0800, Yonggang Luo wrote:
> Also it's fixes issues about make check
> 
> Yonggang Luo (12):
>   configure: fixes dtc not cloned when running msys2 CI
>   meson: Convert undefsym.sh to undefsym.py
>   tcg: Fixes dup_const link error
>   tests: handling signal on win32 properly
>   configure: Fix include and linkage issue on msys2
>   block: Fixes nfs on msys2/mingw
>   osdep: These function are only available on Non-Win32 system.
>   ci: fixes msys2 build by upgrading capstone to 4.0.2
>   stubs: qemu_notify_event have no need to stub
>   meson: Fixes qapi tests.
>   tests: Disable test-image-locking that not works under Win32
>   ci: Enable msys2 ci in cirrus
> 
>  .cirrus.yml                         |   108 +-
>  block/nfs.c                         |  1812 +--
>  capstone                            |     2 +-
>  configure                           | 16560 +++++++++++++-------------
>  include/qemu/osdep.h                |  1372 +--
>  include/tcg/tcg.h                   |  2898 ++---
>  meson.build                         |  2994 ++---
>  scripts/ci/windows/msys2_build.sh   |    33 +
>  scripts/ci/windows/msys2_install.sh |    31 +
>  scripts/undefsym.py                 |    57 +
>  scripts/undefsym.sh                 |    20 -
>  stubs/notify-event.c                |     8 +-
>  tcg/tcg-op-gvec.c                   |  7012 +++++------
>  tests/Makefile.include              |  1086 +-
>  tests/qapi-schema/meson.build       |   451 +-
>  tests/test-replication.c            |  1214 +-
>  16 files changed, 17904 insertions(+), 17754 deletions(-)

This whole series is messed up adding/removing 1000's of lines of
code with no change. I'm assuming you've introduced DOS line
endings causing a massive diff


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|