[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/63] gpex: Fix type checking function name
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 01/63] gpex: Fix type checking function name |
Date: |
Thu, 3 Sep 2020 14:48:27 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/3/20 12:42 AM, Eduardo Habkost wrote:
> This looks like a copy/paste mistake: the instance type checking
> macro for TYPE_GPEX_ROOT_DEVICE was named MCH_PCI_DEVICE.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Cc: qemu-devel@nongnu.org
> ---
> include/hw/pci-host/gpex.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/pci-host/gpex.h b/include/hw/pci-host/gpex.h
> index e8432eced8..2f4e852eee 100644
> --- a/include/hw/pci-host/gpex.h
> +++ b/include/hw/pci-host/gpex.h
> @@ -32,7 +32,7 @@ DECLARE_INSTANCE_CHECKER(GPEXHost, GPEX_HOST,
>
> #define TYPE_GPEX_ROOT_DEVICE "gpex-root"
> typedef struct GPEXRootState GPEXRootState;
> -DECLARE_INSTANCE_CHECKER(GPEXRootState, MCH_PCI_DEVICE,
> +DECLARE_INSTANCE_CHECKER(GPEXRootState, GPEX_ROOT_DEVICE,
> TYPE_GPEX_ROOT_DEVICE)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> #define GPEX_NUM_IRQS 4
>
- [PATCH 00/63] qom: Rename macros for consistency, Eduardo Habkost, 2020/09/02
- [PATCH 01/63] gpex: Fix type checking function name, Eduardo Habkost, 2020/09/02
- Re: [PATCH 01/63] gpex: Fix type checking function name,
Philippe Mathieu-Daudé <=
- [PATCH 03/63] chardev: Rename TYPE_BRAILLE_CHARDEV to TYPE_BAUM_CHARDEV, Eduardo Habkost, 2020/09/02
- [PATCH 02/63] chardev: Rename TYPE_CHARDEV_* to TYPE_*_CHARDEV, Eduardo Habkost, 2020/09/02
- [PATCH 04/63] chardev: Rename TYPE_MSMOUSE_CHARDEV to TYPE_MOUSE_CHARDEV, Eduardo Habkost, 2020/09/02
- [PATCH 05/63] ap-device: Rename AP_DEVICE_TYPE to TYPE_AP_DEVICE, Eduardo Habkost, 2020/09/02
- [PATCH 07/63] rdma: Rename PVRDMA_HW_NAME to TYPE_PVRDMA_DEV, Eduardo Habkost, 2020/09/02
- [PATCH 08/63] vfio: Rename VFIO_AP_DEVICE_TYPE to TYPE_VFIO_AP_DEVICE, Eduardo Habkost, 2020/09/02