[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] decodetree: Improve identifier matching
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] decodetree: Improve identifier matching |
|
Date: |
Thu, 3 Sep 2020 22:04:04 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/3/20 9:23 PM, Richard Henderson wrote:
> Only argument set members have to be C identifiers, everything
> else gets prefixed during conversion to C. Some places just
> checked the leading character, and some places matched a leading
> character plus a C identifier.
>
> Convert everything to match full identifiers, including the
> [&%@&] prefix, and drop the full C identifier requirement.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> tests/decode/succ_ident1.decode | 7 +++++
> scripts/decodetree.py | 46 +++++++++++++++++++++------------
> 2 files changed, 37 insertions(+), 16 deletions(-)
> create mode 100644 tests/decode/succ_ident1.decode