qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

i440fx/acpi: don't hot-unplug cold plugged bridges when their hotplug sw


From: Ani Sinha
Subject: i440fx/acpi: don't hot-unplug cold plugged bridges when their hotplug switch is off
Date: Fri, 4 Sep 2020 13:54:50 +0530

I have seen that when hotplug for pci bridge devices are turned off and devices 
are attached
behind the bridge, I still see Windows trying to hot remove the pci bridge and 
failing. Today
looking at the AML disassembly, I realized that we are addding slot enumeration 
and EJ0
methods even for the slot where the bridge is attached. 

Please see the video: https://youtu.be/pME2sjyQweo

This does not seem right. A cold-plugged bridge should not be hot removable 
under any
conditions. Hence, this patch tries to address this. After the change, as the 
demo video
shows, Windows no longer shows the bridge device as hot removable:  
https://youtu.be/kbgej5B9Hgs
under the same test settings.

Requesting comments for this fix.

--Ani
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]