qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] configure: the error info not consistence with option.


From: Yonggang Luo
Subject: Re: [PATCH] configure: the error info not consistence with option.
Date: Sat, 5 Sep 2020 13:43:58 +0800



On Fri, Sep 4, 2020 at 3:54 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
On 04/09/20 05:54, 罗勇刚(Yonggang Luo) wrote:
>
>          test "$vhost_net_user" = "" && vhost_net_user=$vhost_user
>          if test "$vhost_net_user" = "yes" && test "$vhost_user" = "no";
>         then
>         -  error_exit "--enable-vhost-net-user requires --enable-vhost-user"
>         +  error_exit "--enable-vhost-net requires --enable-vhost-user"
>          fi
>
>
>     This change seems wrong.
>
> I didn't found --enable-vhost-net-user option handling?
> you may grep it? 
>
>

You're right, it is all dead code.  The four lines are equivalent to
just vhost_net_user=$vhost_user.  You could also add
--enable-vhost-net-user though!
I remove those four lines and use vhost_net_user=$vhost_user instead for simplicity,
if we have no strong need of this option, i guess remove it are better

Thanks,

Paolo



--
         此致

罗勇刚
Yours
    sincerely,
Yonggang Luo

reply via email to

[Prev in Thread] Current Thread [Next in Thread]