On 05/09/2020 08.23, Yonggang Luo wrote:
> This reverts commit 48328880fddf0145bdccc499160fb24dfabfbd41.
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
> configure | 16 +---------------
> 1 file changed, 1 insertion(+), 15 deletions(-)
Please be a little bit more descriptive in the patch description: Why do
you have to revert this patch?
It shouldn't be reverted yet. The Windows issue that required the introduction of --ninja is now fixed in upstream Meson, but we shouldn't include the fix in the meson submodule until it's part of a released version. We can then bump the required version (hopefully 0.55.2) and decide whether to remove --ninja.
That said, we might also want to use ninja instead of make in the future to build QEMU (leaving make to do the orchestration of the submodules etc.), which would let us remove ninjatool altogether. I am not sure if that is going to happen anytime soon, but it should be taken into account before deciding to remove --ninja.
Paolo