[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] meson: remove duplicate qxl sources
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 2/2] meson: remove duplicate qxl sources |
|
Date: |
Mon, 7 Sep 2020 10:08:02 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/7/20 9:19 AM, Gerd Hoffmann wrote:
> We should add sources to the softmmu_ss or module_ss but not both.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/display/meson.build | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/hw/display/meson.build b/hw/display/meson.build
> index 78adaf9db463..ef8eb093acbb 100644
> --- a/hw/display/meson.build
> +++ b/hw/display/meson.build
> @@ -45,8 +45,6 @@ if config_all_devices.has_key('CONFIG_QXL')
> hw_display_modules += {'qxl': qxl_ss}
> endif
>
> -softmmu_ss.add(when: 'CONFIG_QXL', if_true: files('qxl.c', 'qxl-logger.c',
> 'qxl-render.c'))
> -
> softmmu_ss.add(when: 'CONFIG_DPCD', if_true: files('dpcd.c'))
> softmmu_ss.add(when: 'CONFIG_XLNX_ZYNQMP_ARM', if_true: files('xlnx_dp.c'))
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>