[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH-for-5.2 4/5] qom: Let ObjectPropertyGet functions return
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [RFC PATCH-for-5.2 4/5] qom: Let ObjectPropertyGet functions return a boolean value |
|
Date: |
Mon, 7 Sep 2020 16:36:46 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/7/20 4:26 PM, Markus Armbruster wrote:
> Making more functions taking Error ** return bool (commit
> b6d7e9b66f..a43770df5d) created a number of false positive
> CHECKED_RETURN Coverity issues. Peter notified me back then. This
> series could help (we'd have to double-check), but it covers only the
> getters, not the setters.
>
> Peter, are you still interested in reducing the false positives (as
> opposed to marking them)?
>
> Philippe, are you still pursuing this series?
Have you looked at/audited the ObjectPropertySet call sites?
I'm not sure updating ObjectPropertySet is really interesting,
and only changing ObjectPropertyGet letting an impaired API
doesn't seem a great idea :)