Re: [PATCH v3 05/15] iotests: update snapshot test for new output format

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 05/15] iotests: update snapshot test for new output format

From:	Pavel Dovgalyuk
Subject:	Re: [PATCH v3 05/15] iotests: update snapshot test for new output format
Date:	Mon, 7 Sep 2020 18:41:47 +0300
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 07.09.2020 18:26, Alex Bennée wrote:


Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru> writes:

From: Pavel Dovgalyuk <pavel.dovgaluk@gmail.com>

This patch updates iotests that verify qemu monitor output.
New output format for snapshot listing include ICOUNT column.


I was curious if the monitor should still function during replay. In my
setup:

   ./qemu-system-aarch64 -cpu cortex-a53 -display none -serial mon:stdio 
-machine virt -kernel zephyr.elf -net none -icount 
shift=6,align=off,sleep=off,rr=replay,rrfile=record.out -drive 
file=record.qcow2,if=none,snapshot,id=rr -s -S
   *** Booting Zephyr OS build zephyr-v2.3.0-1183-ge5628ad0faf3  ***
   Hello World! qemu_cortex_a53
   qemu-system-aarch64: Missing character write event in the replay log


And what about -monitor stdio instead of -serial mon:stdio?


although technically the C-a shouldn't be a character that ever makes it
to the guest.


Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
---
  tests/qemu-iotests/267.out |   48 ++++++++++++++++++++++----------------------
  1 file changed, 24 insertions(+), 24 deletions(-)

diff --git a/tests/qemu-iotests/267.out b/tests/qemu-iotests/267.out
index 215902b3ad..27471ffae8 100644
--- a/tests/qemu-iotests/267.out
+++ b/tests/qemu-iotests/267.out
@@ -33,8 +33,8 @@ QEMU X.Y.Z monitor - type 'help' for more information
  (qemu) savevm snap0
  (qemu) info snapshots
  List of snapshots present on all disks:
-ID        TAG                 VM SIZE                DATE       VM CLOCK
---        snap0                  SIZE yyyy-mm-dd hh:mm:ss   00:00:00.000
+ID        TAG               VM SIZE                DATE     VM CLOCK     ICOUNT
+--        snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
  (qemu) loadvm snap0
  (qemu) quit

@@ -44,8 +44,8 @@ QEMU X.Y.Z monitor - type 'help' for more information

  (qemu) savevm snap0
  (qemu) info snapshots
  List of snapshots present on all disks:
-ID        TAG                 VM SIZE                DATE       VM CLOCK
---        snap0                  SIZE yyyy-mm-dd hh:mm:ss   00:00:00.000
+ID        TAG               VM SIZE                DATE     VM CLOCK     ICOUNT
+--        snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
  (qemu) loadvm snap0
  (qemu) quit

@@ -69,8 +69,8 @@ QEMU X.Y.Z monitor - type 'help' for more information

  (qemu) savevm snap0
  (qemu) info snapshots
  List of snapshots present on all disks:
-ID        TAG                 VM SIZE                DATE       VM CLOCK
---        snap0                  SIZE yyyy-mm-dd hh:mm:ss   00:00:00.000
+ID        TAG               VM SIZE                DATE     VM CLOCK     ICOUNT
+--        snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
  (qemu) loadvm snap0
  (qemu) quit

@@ -94,8 +94,8 @@ QEMU X.Y.Z monitor - type 'help' for more information

  (qemu) savevm snap0
  (qemu) info snapshots
  List of snapshots present on all disks:
-ID        TAG                 VM SIZE                DATE       VM CLOCK
---        snap0                  SIZE yyyy-mm-dd hh:mm:ss   00:00:00.000
+ID        TAG               VM SIZE                DATE     VM CLOCK     ICOUNT
+--        snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
  (qemu) loadvm snap0
  (qemu) quit

@@ -105,8 +105,8 @@ QEMU X.Y.Z monitor - type 'help' for more information

  (qemu) savevm snap0
  (qemu) info snapshots
  List of snapshots present on all disks:
-ID        TAG                 VM SIZE                DATE       VM CLOCK
---        snap0                  SIZE yyyy-mm-dd hh:mm:ss   00:00:00.000
+ID        TAG               VM SIZE                DATE     VM CLOCK     ICOUNT
+--        snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
  (qemu) loadvm snap0
  (qemu) quit

@@ -119,8 +119,8 @@ QEMU X.Y.Z monitor - type 'help' for more information

  (qemu) savevm snap0
  (qemu) info snapshots
  List of snapshots present on all disks:
-ID        TAG                 VM SIZE                DATE       VM CLOCK
---        snap0                  SIZE yyyy-mm-dd hh:mm:ss   00:00:00.000
+ID        TAG               VM SIZE                DATE     VM CLOCK     ICOUNT
+--        snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
  (qemu) loadvm snap0
  (qemu) quit

@@ -134,8 +134,8 @@ QEMU X.Y.Z monitor - type 'help' for more information

  (qemu) savevm snap0
  (qemu) info snapshots
  List of snapshots present on all disks:
-ID        TAG                 VM SIZE                DATE       VM CLOCK
---        snap0                  SIZE yyyy-mm-dd hh:mm:ss   00:00:00.000
+ID        TAG               VM SIZE                DATE     VM CLOCK     ICOUNT
+--        snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
  (qemu) loadvm snap0
  (qemu) quit

@@ -145,15 +145,15 @@ QEMU X.Y.Z monitor - type 'help' for more information

  (qemu) savevm snap0
  (qemu) info snapshots
  List of snapshots present on all disks:
-ID        TAG                 VM SIZE                DATE       VM CLOCK
---        snap0                  SIZE yyyy-mm-dd hh:mm:ss   00:00:00.000
+ID        TAG               VM SIZE                DATE     VM CLOCK     ICOUNT
+--        snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
  (qemu) loadvm snap0
  (qemu) quit

Internal snapshots on overlay:

  Snapshot list:
-ID        TAG                 VM SIZE                DATE       VM CLOCK
-1         snap0                  SIZE yyyy-mm-dd hh:mm:ss   00:00:00.000
+ID        TAG               VM SIZE                DATE     VM CLOCK     ICOUNT
+1         snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
  Internal snapshots on backing file:

=== -blockdev with NBD server on the backing file ===

@@ -166,17 +166,17 @@ QEMU X.Y.Z monitor - type 'help' for more information
  (qemu) savevm snap0
  (qemu) info snapshots
  List of snapshots present on all disks:
-ID        TAG                 VM SIZE                DATE       VM CLOCK
---        snap0                  SIZE yyyy-mm-dd hh:mm:ss   00:00:00.000
+ID        TAG               VM SIZE                DATE     VM CLOCK     ICOUNT
+--        snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
  (qemu) loadvm snap0
  (qemu) quit

Internal snapshots on overlay:

  Snapshot list:
-ID        TAG                 VM SIZE                DATE       VM CLOCK
-1         snap0                  SIZE yyyy-mm-dd hh:mm:ss   00:00:00.000
+ID        TAG               VM SIZE                DATE     VM CLOCK     ICOUNT
+1         snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
  Internal snapshots on backing file:
  Snapshot list:
-ID        TAG                 VM SIZE                DATE       VM CLOCK
-1         snap0                  SIZE yyyy-mm-dd hh:mm:ss   00:00:00.000
+ID        TAG               VM SIZE                DATE     VM CLOCK     ICOUNT
+1         snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
  *** done

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v3 00/15] Reverse debugging, Pavel Dovgalyuk, 2020/09/02
- [PATCH v3 01/15] replay: don't record interrupt poll, Pavel Dovgalyuk, 2020/09/02
  - Re: [PATCH v3 01/15] replay: don't record interrupt poll, Alex Bennée, 2020/09/07
- [PATCH v3 02/15] replay: provide an accessor for rr filename, Pavel Dovgalyuk, 2020/09/02
- [PATCH v3 03/15] qcow2: introduce icount field for snapshots, Pavel Dovgalyuk, 2020/09/02
- [PATCH v3 04/15] migration: introduce icount field for snapshots, Pavel Dovgalyuk, 2020/09/02
- [PATCH v3 05/15] iotests: update snapshot test for new output format, Pavel Dovgalyuk, 2020/09/02
  - Re: [PATCH v3 05/15] iotests: update snapshot test for new output format, Alex Bennée, 2020/09/07
    - Re: [PATCH v3 05/15] iotests: update snapshot test for new output format, Pavel Dovgalyuk <=
    - Re: [PATCH v3 05/15] iotests: update snapshot test for new output format, Alex Bennée, 2020/09/07
    - Re: [PATCH v3 05/15] iotests: update snapshot test for new output format, Pavel Dovgalyuk, 2020/09/07
  - Re: [PATCH v3 05/15] iotests: update snapshot test for new output format, Eric Blake, 2020/09/08
- [PATCH v3 06/15] qapi: introduce replay.json for record/replay-related stuff, Pavel Dovgalyuk, 2020/09/02
- [PATCH v3 07/15] replay: introduce info hmp/qmp command, Pavel Dovgalyuk, 2020/09/02
- [PATCH v3 08/15] replay: introduce breakpoint at the specified step, Pavel Dovgalyuk, 2020/09/02
- [PATCH v3 09/15] replay: implement replay-seek command, Pavel Dovgalyuk, 2020/09/02
  - Re: [PATCH v3 09/15] replay: implement replay-seek command, Alex Bennée, 2020/09/07
    - Re: [PATCH v3 09/15] replay: implement replay-seek command, Pavel Dovgalyuk, 2020/09/07
  - Re: [PATCH v3 09/15] replay: implement replay-seek command, Alex Bennée, 2020/09/07

Prev by Date: Re: [PATCH v2 13/15] scripts/oss-fuzz: build the general-fuzzer configs
Next by Date: Re: [PATCH v2 02/15] fuzz: Add general virtual-device fuzzer
Previous by thread: Re: [PATCH v3 05/15] iotests: update snapshot test for new output format
Next by thread: Re: [PATCH v3 05/15] iotests: update snapshot test for new output format
Index(es):
- Date
- Thread