[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] virtio-iommu: Check gtrees are non null before destroyin
|
From: |
Cornelia Huck |
|
Subject: |
Re: [PATCH 1/2] virtio-iommu: Check gtrees are non null before destroying them |
|
Date: |
Mon, 7 Sep 2020 18:09:25 +0200 |
On Wed, 2 Sep 2020 15:11:51 +0200
Eric Auger <eric.auger@redhat.com> wrote:
> If realize fails, domains and endpoints trees may be NULL. On
> unrealize(), this produces asseryions:
s/asseryions/assertions/
> "GLib: g_tree_destroy: assertion 'tree != NULL' failed"
>
> Check the tree are non NULL before destroying them.
s/the tree/that the trees/
>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> ---
> hw/virtio/virtio-iommu.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Good to see that the version checking has flushed out a bug :)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>