[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 07/21] tests: Trying fixes test-replication.c on msys2/min
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2 07/21] tests: Trying fixes test-replication.c on msys2/mingw. |
Date: |
Wed, 9 Sep 2020 13:55:50 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Wed, Sep 09, 2020 at 05:46:03PM +0800, Yonggang Luo wrote:
> On Windows there is no path like /tmp/s_local_disk.XXXXXX
> Use g_get_tmp_dir instead of /tmp.
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
> tests/test-replication.c | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> @@ -571,6 +571,11 @@ static void setup_sigabrt_handler(void)
> int main(int argc, char **argv)
> {
> int ret;
> + const char *tmpdir = g_get_tmp_dir();
> + p_local_disk = g_strdup_printf("%s/p_local_disk.XXXXXX", tmpdir);
> + s_local_disk = g_strdup_printf("%s/s_local_disk.XXXXXX", tmpdir);
> + s_active_disk = g_strdup_printf("%s/s_active_disk.XXXXXX", tmpdir);
> + s_hidden_disk = g_strdup_printf("%s/s_hidden_disk.XXXXXX", tmpdir);
I presume msys is taking care of translating "/" into "\" so that
we don't need to use g_build_filename to use the native directory
separator straightaway ?
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v2 03/21] configure: Fixes ncursesw detection under msys2/mingw and enable curses, (continued)
- [PATCH v2 03/21] configure: Fixes ncursesw detection under msys2/mingw and enable curses, Yonggang Luo, 2020/09/09
- [PATCH v2 04/21] curses: Fixes curses compiling errors., Yonggang Luo, 2020/09/09
- [PATCH v2 05/21] tests: disable /char/stdio/* tests in test-char.c on win32, Yonggang Luo, 2020/09/09
- [PATCH v2 06/21] ci: Enable msys2 ci in cirrus, Yonggang Luo, 2020/09/09
- [PATCH v2 07/21] tests: Trying fixes test-replication.c on msys2/mingw., Yonggang Luo, 2020/09/09
- Re: [PATCH v2 07/21] tests: Trying fixes test-replication.c on msys2/mingw.,
Daniel P . Berrangé <=
- [PATCH v2 08/21] tests: test-replication disable /replication/secondary/* on msys2/mingw., Yonggang Luo, 2020/09/09
- [PATCH v2 09/21] osdep: These function are only available on Non-Win32 system., Yonggang Luo, 2020/09/09
- [PATCH v2 10/21] meson: Use -b to ignore CR vs. CR-LF issues on Windows, Yonggang Luo, 2020/09/09
- [PATCH v2 11/21] meson: disable crypto tests are empty under win32, Yonggang Luo, 2020/09/09
- [PATCH v2 12/21] meson: remove empty else and duplicated gio deps, Yonggang Luo, 2020/09/09