Re: [PULL 00/34] QOM boilerplate cleanup (v3)

[Peter Maydell]

On Tue, 8 Sep 2020 at 22:52, Eduardo Habkost <ehabkost@redhat.com> wrote:
>
> Changes v2 -> v3:
> * Fix build errors: dropped all changes in
>   include/hw/riscv/sifive* and include/accel/accel.h
>
> The following changes since commit 6779038537360e957dbded830f76b08ef5070161:
>
>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-09-08' int=
> o staging (2020-09-08 17:23:31 +0100)
>
> are available in the Git repository at:
>
>   git://github.com/ehabkost/qemu.git tags/machine-next-pull-request
>
> for you to fetch changes up to 7661577c45301bf37a56988eeb084e01bd119de7:
>
>   virtio-vga: Use typedef name for instance_size (2020-09-08 17:32:01 -0400)
>
> ----------------------------------------------------------------
> QOM boilerplate cleanup
>
> Documentation build fix:
> * memory: Remove kernel-doc comment marker (Eduardo Habkost)
>
> QOM cleanups:
> * Rename QOM macros for consistency between
>   TYPE_* and type checking constants (Eduardo Habkost)
>
> QOM new macros:
> * OBJECT_DECLARE_* and OBJECT_DEFINE_* macros (Daniel P. Berrang=C3=A9)
> * DECLARE_*_CHECKER macros (Eduardo Habkost)
>
> Automated QOM boilerplate changes:
> * Automated changes to use DECLARE_*_CHECKER (Eduardo Habkost
> * Automated changes to use OBJECT_DECLARE* (Eduardo Habkost)

Link failure on FreeBSD trying to build tests/test-char:

cc  -o tests/test-char tests/test-char.p/test-char.c.o
tests/test-char.p/socket-helpers.c.o -Wl,--as-needed
-Wl,--no-undefined -pie -Wl,--whole-archive qom/libqom.fa io/libio.fa
crypto/libcrypto.fa authz/libauthz.fa chardev/libchardev.fa
-Wl,--no-whole-archive -Wl,-z,relro -Wl,-z,now -m64
-fstack-protector-strong -Wl,--start-group libqemuutil.a qom/libqom.fa
io/libio.fa crypto/libcrypto.fa authz/libauthz.fa
chardev/libchardev.fa -L/usr/local/lib -lgnutls -L/usr/local/lib
-lgio-2.0 -lgobject-2.0 -lglib-2.0 -lintl -L/usr/local/lib -lgio-2.0
-lgobject-2.0 -lglib-2.0 -lintl -pthread -lutil -lm -L/usr/local/lib
-lgthread-2.0 -lglib-2.0 -lintl -L/usr/local/lib -lgnutls
-L/usr/local/lib -lnettle -lpam -Wl,--end-group
ld: error: undefined symbol: PARALLEL_CHARDEV
>>> referenced by char-parallel.c:236 (../src/chardev/char-parallel.c:236)
>>>               char-parallel.c.o:(qmp_chardev_open_parallel) in archive 
>>> chardev/libchardev.fa

ld: error: undefined symbol: PARALLEL_CHARDEV
>>> referenced by char-parallel.c:191 (../src/chardev/char-parallel.c:191)
>>>               char-parallel.c.o:(pp_ioctl) in archive chardev/libchardev.fa
cc: error: linker command failed with exit code 1 (use -v to see invocation)
gmake: *** [Makefile.ninja:5822: tests/test-char] Error 1
gmake: *** Waiting for unfinished jobs....

All other platforms built OK.

thanks
-- PMM