Re: [PATCH v5 2/2] hw: hyperv: vmbus: Fix 32bit compilation

[Laurent Vivier]

Le 06/09/2020 à 12:14, Philippe Mathieu-Daudé a écrit :
> Cc'ing qemu-trivial@
> 
> Can we add the commit description Richard wrote?

I have no message from Richard regarding this patch.

Thanks,
Laurent
> 
> ---
> Fix 32-bit build error for vmbus:
> 
>   hw/hyperv/vmbus.c: In function ‘gpadl_iter_io’:
>   hw/hyperv/vmbus.c:383:13: error: cast to pointer from integer of
> different size [-Werror=int-to-pointer-cast]
>   383 |         p = (void *)(((uintptr_t)iter->map & TARGET_PAGE_MASK) |
> off_in_page);
>       |             ^
>   cc1: all warnings being treated as errors
> 
> Fixes: 0d71f7082d7 ("vmbus: vmbus implementation")
> ---
> 
> On 7/15/20 10:43 AM, Jon Doron wrote:
>> Signed-off-by: Jon Doron <arilou@gmail.com>
>> ---
>>  hw/hyperv/vmbus.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c
>> index 34392e892a..c28bb4201b 100644
>> --- a/hw/hyperv/vmbus.c
>> +++ b/hw/hyperv/vmbus.c
>> @@ -383,7 +383,8 @@ static ssize_t gpadl_iter_io(GpadlIter *iter, void *buf, 
>> uint32_t len)
>>              }
>>          }
>>  
>> -        p = (void *)(((uintptr_t)iter->map & TARGET_PAGE_MASK) | 
>> off_in_page);
>> +        p = (void *)(uintptr_t)(((uintptr_t)iter->map & TARGET_PAGE_MASK) |
>> +                off_in_page);
>>          if (iter->dir == DMA_DIRECTION_FROM_DEVICE) {
>>              memcpy(p, buf, cplen);
>>          } else {
>>
> 
>