[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [EXTERNAL] Re: [PATCH] configure: Do not intent to build WHPX on 32-
From: |
Sunil Muthuswamy |
Subject: |
RE: [EXTERNAL] Re: [PATCH] configure: Do not intent to build WHPX on 32-bit host |
Date: |
Wed, 9 Sep 2020 20:12:47 +0000 |
Signed-off-by: Sunil Muthuswamy <sunilmut@microsoft.com>
> Am 09.09.20 um 20:40 schrieb Thomas Huth:
>
> > On 09/09/2020 20.24, Philippe Mathieu-Daudé wrote:
> >> Hyper-V is available on 64-bit versions of Windows,
> >> do not try to build its support on 32-bit versions.
> >>
> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >> ---
> >> configure | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/configure b/configure
> >> index 4231d56bcc0..4bd08f5469b 100755
> >> --- a/configure
> >> +++ b/configure
> >> @@ -2989,6 +2989,9 @@ if test "$whpx" != "no" ; then
> >> fi
> >> whpx="no"
> >> fi
> >> + if test "$whpx" = "yes" && test "$ARCH" = "i386"; then
> >> + error_exit "WHPX requires 64-bit host"
> >> + fi
> >> fi
> > I think you should also add a check to the MINGW32 case (see commit
> > e7a222aeb813a) to prevent that the automatic detection kicks in (so that
> > you would end up with this error message even if you did not specify
> > --enable-whpx)
> >
> > Thomas
> >
>
> Yes, that's definitely required. The automatic detection currently
> enables WHPX for 32 bit builds, too.
>
> Stefan
>