[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 09/12] hw/arm/virt: spe: Add SPE fdt binding for virt mach
|
From: |
Haibo Xu |
|
Subject: |
Re: [PATCH v2 09/12] hw/arm/virt: spe: Add SPE fdt binding for virt machine |
|
Date: |
Thu, 10 Sep 2020 08:31:27 +0800 |
On Wed, 9 Sep 2020 at 17:34, Andrew Jones <drjones@redhat.com> wrote:
>
> On Wed, Sep 09, 2020 at 03:51:14PM +0800, Haibo Xu wrote:
> > > > +
> > > > + if (spe) {
> > > > + assert(ARM_CPU(cpu)->has_spe == ON_OFF_AUTO_ON);
> > > > + if (kvm_irqchip_in_kernel()) {
> > > > + kvm_arm_spe_set_irq(cpu, PPI(VIRTUAL_SPE_IRQ));
> > > > + }
> > > > + kvm_arm_spe_init(cpu);
> > >
> > > A later patch introduces userspace irqchip support. Should we avoid
> > > allowing it until then to avoid breaking bisection?
> > >
> >
> > Yes, it's possible to break the bisection. To avoid it I think we can
> > move the above codes
> > block to a separate patch after adding the userspace irqchip support,
> > Or, just put the userspace
> > irqchip support patch before this patch. What's your opinion?
> >
>
> This patch ca forbid SPE without kernel irqchip. Then the patch that adds
> userspace irqchip support would also remove the restriction.
>
> Thanks,
> drew
>
Good idea! Will fix it in v3.
- Re: [PATCH v2 03/12] target/arm/cpu: spe: Add an option to turn on/off vSPE support, (continued)
[PATCH v2 08/12] hw/arm/virt: Move kvm pmu setup to virt_cpu_post_init, Haibo Xu, 2020/09/08
[PATCH v2 10/12] target/arm/cpu: spe: Enable spe to work with host cpu, Haibo Xu, 2020/09/08
[PATCH v2 11/12] target/arm/kvm: spe: Enable userspace irqchip support., Haibo Xu, 2020/09/08
[PATCH v2 12/12] target/arm: spe: Add corresponding doc and test., Haibo Xu, 2020/09/08