[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 02/10] usb-host: restrict workaround to new libusb versions
From: |
Igor Mammedov |
Subject: |
Re: [PULL 02/10] usb-host: restrict workaround to new libusb versions |
Date: |
Fri, 11 Sep 2020 10:49:07 +0200 |
On Thu, 10 Sep 2020 14:14:56 +0100
Alex Bennée <alex.bennee@linaro.org> wrote:
> From: Gerd Hoffmann <kraxel@redhat.com>
>
> Fixes build failures with old kernels (USBDEVFS_GET_SPEED missing),
> on the assumtion that distros with old kernels also have old libusb.
>
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Message-Id: <20200902081445.3291-1-kraxel@redhat.com>
> Message-Id: <20200909112742.25730-3-alex.bennee@linaro.org>
Can we get this merged to fix travis-ci builds, please.
>
> diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c
> index 08604f787fd..c5d38cb09c0 100644
> --- a/hw/usb/host-libusb.c
> +++ b/hw/usb/host-libusb.c
> @@ -942,7 +942,7 @@ static int usb_host_open(USBHostDevice *s, libusb_device
> *dev, int hostfd)
> usb_host_ep_update(s);
>
> libusb_speed = libusb_get_device_speed(dev);
> -#ifdef CONFIG_LINUX
> +#if LIBUSB_API_VERSION >= 0x01000107 && defined(CONFIG_LINUX)
> if (hostfd && libusb_speed == 0) {
> /*
> * Workaround libusb bug: libusb_get_device_speed() does not
- [PULL 00/10] testing and other mix fixes, Alex Bennée, 2020/09/10
- [PULL 01/10] CODING_STYLE.rst: flesh out our naming conventions., Alex Bennée, 2020/09/10
- [PULL 02/10] usb-host: restrict workaround to new libusb versions, Alex Bennée, 2020/09/10
- Re: [PULL 02/10] usb-host: restrict workaround to new libusb versions,
Igor Mammedov <=
- [PULL 05/10] docs/system/deprecated: mark ppc64abi32-linux-user for deprecation, Alex Bennée, 2020/09/10
- [PULL 04/10] target/mips: simplify gen_compute_imm_branch logic, Alex Bennée, 2020/09/10
- [PULL 03/10] tests/meson.build: fp tests don't need CONFIG_TCG, Alex Bennée, 2020/09/10
- [PULL 07/10] hw/i386: make explicit clearing of pch_rev_id, Alex Bennée, 2020/09/10
- [PULL 06/10] configure: don't enable ppc64abi32-linux-user by default, Alex Bennée, 2020/09/10
- [PULL 10/10] plugins: move the more involved plugins to contrib, Alex Bennée, 2020/09/10
- [PULL 08/10] tests: bump avocado version, Alex Bennée, 2020/09/10
- [PULL 09/10] tests/acceptance: Add Test.fetch_asset(cancel_on_missing=True), Alex Bennée, 2020/09/10