[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL v2 01/46] qemu-iotests: move check-block back to Makefiles
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PULL v2 01/46] qemu-iotests: move check-block back to Makefiles |
|
Date: |
Fri, 11 Sep 2020 13:19:57 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 11/09/20 13:05, Max Reitz wrote:
> On closer inspection it seems like it’s because of the
> “build_by_default: false”, which seems like a rather conscious decision.
> Was I only lucky that the socket_scm_helper was built by default so
> far? Should I have explicitly built it all this time?
Yes, you were lucky but that's not a reason not to change it.
The problem with touching a whole build system is that you are not going
to test everybody's usecase, and yours is definitely reasonable and not
"M-x butterfly" territory.
Paolo
signature.asc
Description: OpenPGP digital signature