qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 0/9] user-mode: Prune build dependencies (part 2)


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v4 0/9] user-mode: Prune build dependencies (part 2)
Date: Sun, 13 Sep 2020 17:51:32 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 9/13/20 3:40 PM, Paolo Bonzini wrote:
> On 13/09/20 13:31, Philippe Mathieu-Daudé wrote:
>>> I'm not sure about the first.  It's a bit ugly to have a property whose
>>> getter aborts.
>> This is (IIUC) the change Markus requested in v3 (see [*]).
>>
>> Commit description: "add a stub to satisfy the linker."
>>
>> This stub should be never used on user-mode => abort.
>>
>> [*] https://www.mail-archive.com/qemu-block@nongnu.org/msg67560.html
>>
> 
> Yes, I'm not sure about the stub _in general_.  I would prefer to either
> have the type available even on user-mode emulation, or remove the
> property altogether... I don't know, anything but not a property that
> aborts. :)

I plan to eventually get user-mode cleaned, but this is out of the scope
of this generic second part which is already big enough for Laurent to
digest. Maybe part #4 will be x86 specific.

Let's wait for Markus view on this (personally I don't mind removing
the abort, it was not there on v3).

> 
> Paolo
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]