On 13/09/20 00:44, Yonggang Luo wrote:
> This reverts commit 48328880fddf0145bdccc499160fb24dfabfbd41.
>
> The --ninja option doesn't need anymore because of upgrade meson to 0.55.2
> At that version we can use ninjatool
We might actually get rid of ninjatool before QEMU 5.2 goes out, if we
decide to make Ninja a mandatory build dependency. So we can hold on
patches 26 and 27. Thanks for testing though!
I'm also not sure about patch 16, since that's not my area, but Daniel
and Ed both reviewed it so that's okay.
Finally, instead of checking !_WIN32 it's better to check CONFIG_POSIX
or CONFIG_WIN32. That can be changed on commit though.
Everything else seems okay. I'll wait a couple days and queue the whole
bunch up to patch 25.
Paolo
_WIN32 are more precise and only depends on the compiler, on the other hand,
CONFIG_POSIX and
CONFIG_WIN32 need
configure scripts. I prefer
_WIN32 unless the compiler can not provide enough information.
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo