|
From: | Richard Henderson |
Subject: | Re: [PATCH 01/11] capstone: Convert Makefile bits to meson bits |
Date: | Sun, 13 Sep 2020 18:37:53 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 9/13/20 5:01 PM, Richard Henderson wrote: > case "$capstone" in > - git | internal) > + git) > if test "$capstone" = git; then > git_submodules="${git_submodules} capstone" > fi The if here can be removed now. Alternately... > - mkdir -p capstone > - if test "$mingw32" = "yes"; then > - LIBCAPSTONE=capstone.lib > - else > - LIBCAPSTONE=libcapstone.a > - fi > - capstone_libs="-Lcapstone -lcapstone" > - capstone_cflags="-I${source_path}/capstone/include" > ;; > > - system) > - capstone_libs="$($pkg_config --libs capstone)" > - capstone_cflags="$($pkg_config --cflags capstone)" > + internal | system | no) > ;; > > - no) > - ;; > *) > error_exit "Unknown state for capstone: $capstone" > ;; ... stop trying to validate the set of states and instead remove the outer case, leaving only the inner if. Thoughts? r~
[Prev in Thread] | Current Thread | [Next in Thread] |