qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v3] checkpatch: detect missing changes to trace-events


From: Stefan Hajnoczi
Subject: Re: [RFC v3] checkpatch: detect missing changes to trace-events
Date: Mon, 14 Sep 2020 14:44:42 +0100

On Tue, Aug 11, 2020 at 10:11:58AM +0200, Claudio Fontana wrote:
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> ---
>  scripts/checkpatch.pl | 48 ++++++++++++++++++++++++++++++++++++------------
>  1 file changed, 36 insertions(+), 12 deletions(-)
> 
> v2 -> v3 :
> 
> * move the check for missing changes to MAINTAINERS and trace-events
>   later on, as otherwise the check for in_commit_log will not be done
>   on an up to date value, causing fromfile and realfile to not be set,
>   and matching unwanted strings inside the commit log.
> 
> * Ensure that at least one file name is passed to grep.
> 
> 
> ----
> 
> v1 -> v2 :
> 
> * track the "from" file in addition to the "to" file,
>   and grep into both (if they exist), looking for trace.h, trace-root.h
> 
>   If files are reachable and readable, emit a warning if there is no
>   update to trace-events.

This patch still has an RFC tag. Is it ready to be merged?

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]