Re: [PATCH v7 00/13] monitor: Optionally run handlers in coroutines

[Markus Armbruster]

Stefan Hajnoczi <stefanha@redhat.com> writes:

> On Wed, Sep 09, 2020 at 05:11:36PM +0200, Kevin Wolf wrote:
>> Some QMP command handlers can block the main loop for a relatively long
>> time, for example because they perform some I/O. This is quite nasty.
>> Allowing such handlers to run in a coroutine where they can yield (and
>> therefore release the BQL) while waiting for an event such as I/O
>> completion solves the problem.
>> 
>> This series adds the infrastructure to allow this and switches
>> block_resize to run in a coroutine as a first example.
>> 
>> This is an alternative solution to Marc-André's "monitor: add
>> asynchronous command type" series.
>
> Please clarify the following in the QAPI documentation:
>  * Is the QMP monitor suspended while the command is pending?
>  * Are QMP events reported while the command is pending?

Good points.  Kevin, I'd be willing to take this as a follow-up patch,
if that's more convenient for you.

> Acked-by: Stefan Hajnoczi <stefanha@redhat.com>

Stefan, I could use your proper review of PATCH 11-13.  Pretty-please?