[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/11] disas: Enable capstone disassembly for sparc
From: |
Richard Henderson |
Subject: |
Re: [PATCH 11/11] disas: Enable capstone disassembly for sparc |
Date: |
Mon, 14 Sep 2020 14:07:23 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 9/13/20 11:23 PM, Philippe Mathieu-Daudé wrote:
> The old disassembler is easier to follow:
>
> ----------------
> IN:
> -0x4000d214: lda [ %g3 ] #ASI_M_FLUSH_PROBE, %g6
> -0x4000d218: sta %g6, [ %g4 ] #ASI_M_FLUSH_PROBE
> +0x4000d214: cc80c060 .byte 0xcc, 0x80, 0xc0, 0x60
> +0x4000d218: cca10060 .byte 0xcc, 0xa1, 0x00, 0x60
>
> ^ lda/sta opcodes not supported (there might be more).
>
> ----------------
> IN:
> -0x4000d22c: sethi %hi(0xf01f0000), %g1
> -0x4000d230: mov %g1, %g1 ! 0xf01f0000
> -0x4000d234: jmp %g1
> -0x4000d238: nop
> +0x4000d22c: 033c07c0 sethi 0x3c07c0, %g1
> +0x4000d230: 82106000 or %g1, 0, %g1
> +0x4000d234: 81c04000 jmp %g1
> +0x4000d238: 01000000 nop
>
> ^ hi()/lo() macros not expanded (easier to read!)
Hmm, yes. I'm going to drop this for now.
Maybe revisit if this gets fixed upstream.
> Can we restrict dumping the encoded hex content for debug
> profile only?
Why? Including the hex content was in fact requested when I first added the
capstone code.
r~
- Re: [PATCH 05/11] disas: Use qemu/bswap.h for bfd endian loads, (continued)
- [PATCH 04/11] disas: Clean up CPUDebug initialization, Richard Henderson, 2020/09/13
- [PATCH 06/11] disas: Cleanup plugin_disas, Richard Henderson, 2020/09/13
- [PATCH 07/11] disas: Configure capstone for aarch64 host without libvixl, Richard Henderson, 2020/09/13
- [PATCH 09/11] disas: Enable capstone disassembly for s390x, Richard Henderson, 2020/09/13
- [PATCH 08/11] disas: Split out capstone code to disas/capstone.c, Richard Henderson, 2020/09/13
- [PATCH 10/11] disas/capstone: Add skipdata hook for s390x, Richard Henderson, 2020/09/13
- [PATCH 11/11] disas: Enable capstone disassembly for sparc, Richard Henderson, 2020/09/13