Re: [PATCH v5 1/8] qapi: Restrict LostTickPolicy enum to machine code

[Markus Armbruster]

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> +Laurent + qemu-block@
>
> On 9/14/20 11:14 AM, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>> 
>>> Acked-by: Markus Armbruster <armbru@redhat.com>
>>> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> 
>> Unlike the other patches that move code out of misc.json, this one
>> doesn't say "allows pulling less declarations/definitions to user-mode."
>> Intentional?
>
> TBH I don't remember as this is 6months old.
>
> IIUC the "tick lost" feature is only meaningful when running
> virtualized with a RTC profile, so this is pointless for
> user-mode binaries and tools.

Your reply to my question on PATCH 3 "What exactly is being pulled
where before the series, and no more afterwards?" leads me to believe
this patch is no different.  Suggest to add the same rationale to this
commit message.