Re: [PATCH 13/15] spapr: Add a return value to spapr_check

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 13/15] spapr: Add a return value to spapr_check_pagesize()

From:	Philippe Mathieu-Daudé
Subject:	Re: [PATCH 13/15] spapr: Add a return value to spapr_check_pagesize()
Date:	Tue, 15 Sep 2020 15:10:16 +0200
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 9/14/20 2:35 PM, Greg Kurz wrote:
> As recommended in "qapi/error.h", return true on success and false on
> failure. This allows to reduce error propagation overhead in the callers.
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
>  include/hw/ppc/spapr.h | 2 +-
>  hw/ppc/spapr.c         | 4 +---
>  hw/ppc/spapr_caps.c    | 7 +++++--
>  3 files changed, 7 insertions(+), 6 deletions(-)

Reviewed-by: Philippe Mathieu-DaudÃ© <philmd@redhat.com>

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 10/15] spapr: Add a return value to spapr_set_vcpu_id(), (continued)
- [PATCH 10/15] spapr: Add a return value to spapr_set_vcpu_id(), Greg Kurz, 2020/09/14
  - Re: [PATCH 10/15] spapr: Add a return value to spapr_set_vcpu_id(), Vladimir Sementsov-Ogievskiy, 2020/09/15
  - Re: [PATCH 10/15] spapr: Add a return value to spapr_set_vcpu_id(), Philippe Mathieu-Daudé, 2020/09/15
    - Re: [PATCH 10/15] spapr: Add a return value to spapr_set_vcpu_id(), Greg Kurz, 2020/09/15
    - Re: [PATCH 10/15] spapr: Add a return value to spapr_set_vcpu_id(), David Gibson, 2020/09/16
- [PATCH 12/15] spapr: Add a return value to spapr_nvdimm_validate(), Greg Kurz, 2020/09/14
  - Re: [PATCH 12/15] spapr: Add a return value to spapr_nvdimm_validate(), Vladimir Sementsov-Ogievskiy, 2020/09/15
  - Re: [PATCH 12/15] spapr: Add a return value to spapr_nvdimm_validate(), Philippe Mathieu-Daudé, 2020/09/15
- [PATCH 13/15] spapr: Add a return value to spapr_check_pagesize(), Greg Kurz, 2020/09/14
  - Re: [PATCH 13/15] spapr: Add a return value to spapr_check_pagesize(), Vladimir Sementsov-Ogievskiy, 2020/09/15
  - Re: [PATCH 13/15] spapr: Add a return value to spapr_check_pagesize(), Philippe Mathieu-Daudé <=
- [PATCH 14/15] spapr: Simplify error handling in spapr_memory_plug(), Greg Kurz, 2020/09/14
  - Re: [PATCH 14/15] spapr: Simplify error handling in spapr_memory_plug(), Vladimir Sementsov-Ogievskiy, 2020/09/15
    - Re: [SPAM] Re: [PATCH 14/15] spapr: Simplify error handling in spapr_memory_plug(), Greg Kurz, 2020/09/15
    - Re: [SPAM] Re: [PATCH 14/15] spapr: Simplify error handling in spapr_memory_plug(), Vladimir Sementsov-Ogievskiy, 2020/09/15
    - Re: [PATCH 14/15] spapr: Simplify error handling in spapr_memory_plug(), Greg Kurz, 2020/09/15
    - Re: [PATCH 14/15] spapr: Simplify error handling in spapr_memory_plug(), Greg Kurz, 2020/09/15
    - Re: [SPAM] Re: [PATCH 14/15] spapr: Simplify error handling in spapr_memory_plug(), David Gibson, 2020/09/16
    - Re: [SPAM] Re: [PATCH 14/15] spapr: Simplify error handling in spapr_memory_plug(), Markus Armbruster, 2020/09/17
    - Re: [PATCH 14/15] spapr: Simplify error handling in spapr_memory_plug(), Greg Kurz, 2020/09/17
    - Re: [PATCH 14/15] spapr: Simplify error handling in spapr_memory_plug(), Markus Armbruster, 2020/09/17

Prev by Date: Re: [PATCH 12/15] spapr: Add a return value to spapr_nvdimm_validate()
Next by Date: Re: [PATCH] virtio: skip legacy support check on machine types less than 5.1
Previous by thread: Re: [PATCH 13/15] spapr: Add a return value to spapr_check_pagesize()
Next by thread: [PATCH 14/15] spapr: Simplify error handling in spapr_memory_plug()
Index(es):
- Date
- Thread