Re: [PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com

[Willian Rampazzo]

On Thu, Sep 17, 2020 at 1:41 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> Armbian servers are not very reliable and confused the GitLab CI
> users a few times this month (path updated, archives moved, and
> now the SSL: CERTIFICATE_VERIFY_FAILED "certificate has expired"
> error). Time to disable these tests.
> Users can still use the artifacts from the cache (or manually add
> them to the cache).
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  tests/acceptance/boot_linux_console.py | 10 ++++++++++
>  tests/acceptance/replay_kernel.py      |  2 ++
>  2 files changed, 12 insertions(+)
>
> diff --git a/tests/acceptance/boot_linux_console.py 
> b/tests/acceptance/boot_linux_console.py
> index 4a366ce93e4..68534693109 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -485,6 +485,8 @@ def test_arm_exynos4210_initrd(self):
>          self.wait_for_console_pattern('Boot successful.')
>          # TODO user command, for now the uart is stuck
>
> +    @skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
> +                'Test artifacts fetched from unreliable apt.armbian.com')
>      def test_arm_cubieboard_initrd(self):
>          """
>          :avocado: tags=arch:arm
> @@ -525,6 +527,8 @@ def test_arm_cubieboard_initrd(self):
>                                                  'system-control@1c00000')
>          # cubieboard's reboot is not functioning; omit reboot test.
>
> +    @skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
> +                'Test artifacts fetched from unreliable apt.armbian.com')
>      def test_arm_cubieboard_sata(self):
>          """
>          :avocado: tags=arch:arm
> @@ -651,6 +655,8 @@ def test_arm_quanta_gsj_initrd(self):
>          self.wait_for_console_pattern(
>                  'Give root password for system maintenance')
>
> +    @skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
> +                'Test artifacts fetched from unreliable apt.armbian.com')
>      def test_arm_orangepi(self):
>          """
>          :avocado: tags=arch:arm
> @@ -676,6 +682,8 @@ def test_arm_orangepi(self):
>          console_pattern = 'Kernel command line: %s' % kernel_command_line
>          self.wait_for_console_pattern(console_pattern)
>
> +    @skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
> +                'Test artifacts fetched from unreliable apt.armbian.com')
>      def test_arm_orangepi_initrd(self):
>          """
>          :avocado: tags=arch:arm
> @@ -718,6 +726,8 @@ def test_arm_orangepi_initrd(self):
>          # Wait for VM to shut down gracefully
>          self.vm.wait()
>
> +    @skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
> +                'Test artifacts fetched from unreliable apt.armbian.com')
>      def test_arm_orangepi_sd(self):
>          """
>          :avocado: tags=arch:arm
> diff --git a/tests/acceptance/replay_kernel.py 
> b/tests/acceptance/replay_kernel.py
> index b79fc8daf8e..7b4310fccf3 100644
> --- a/tests/acceptance/replay_kernel.py
> +++ b/tests/acceptance/replay_kernel.py
> @@ -127,6 +127,8 @@ def test_arm_virt(self):
>          self.run_rr(kernel_path, kernel_command_line, console_pattern, 
> shift=1)
>
>      @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab')
> +    @skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
> +                'Test artifacts fetched from unreliable apt.armbian.com')
>      def test_arm_cubieboard_initrd(self):
>          """
>          :avocado: tags=arch:arm
> --
> 2.26.2
>
>

Reviewed-by: Willian Rampazzo <willianr@redhat.com>