[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 05/24] Simplify the .gitignore file
From: |
Thomas Huth |
Subject: |
Re: [PULL 05/24] Simplify the .gitignore file |
Date: |
Sat, 19 Sep 2020 12:12:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 18/09/2020 19.33, Peter Maydell wrote:
> On Wed, 16 Sep 2020 at 12:47, Thomas Huth <thuth@redhat.com> wrote:
>>
>> Now that we always do out-of-tree builds (and the in-tree builds are
>> faked via a "build" directory), we can simplify out .gitignore file
>> quite a bit.
>>
>> Message-Id: <20200909080305.258961-1-thuth@redhat.com>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> .gitignore | 152 -----------------------------------------------------
>> 1 file changed, 152 deletions(-)
>
> This change removed .pyc files from the set of things we
> ignore:
>
>> -*.pyc
>
> But the meson build still runs python scripts which live in
> the source tree, which means python still dumps its bytecode
> files in the source tree too, and they appear in 'git status' now:
>
> Untracked files:
> (use "git add <file>..." to include in what will be committed)
>
> docs/sphinx/__pycache__/
> scripts/qapi/__pycache__/
> scripts/tracetool/__pycache__/
> scripts/tracetool/backend/__pycache__/
> scripts/tracetool/format/__pycache__/
>
> So I think we should put *.pyc back into .gitignore.
Ooops, you're right. I'll send a patch.
Thomas
- [PULL 00/24] qtests, unit tests and Cirrus-CI fixes / improvements, Thomas Huth, 2020/09/16
- [PULL 01/24] iotests: Drop readlink -f, Thomas Huth, 2020/09/16
- [PULL 02/24] fuzz: Change the way we write qtest log to stderr, Thomas Huth, 2020/09/16
- [PULL 03/24] tests/qtest/qmp-cmd-test: Use inclusive language, Thomas Huth, 2020/09/16
- [PULL 04/24] tests/socket-helpers: Treat EAI_NONAME as EADDRNOTAVAIL, Thomas Huth, 2020/09/16
- [PULL 06/24] qga/commands-win32: Fix problem with redundant protype declaration, Thomas Huth, 2020/09/16
- [PULL 05/24] Simplify the .gitignore file, Thomas Huth, 2020/09/16
- [PULL 08/24] tests: Convert g_free to g_autofree macro in test-logging.c, Thomas Huth, 2020/09/16
- [PULL 07/24] rcu: Implement drain_call_rcu, Thomas Huth, 2020/09/16
- [PULL 10/24] meson: Disable test-char on msys2/mingw for fixing tests stuck, Thomas Huth, 2020/09/16
- [PULL 09/24] rcu: fixes test-logging.c by call drain_call_rcu before rmdir_full, Thomas Huth, 2020/09/16
- [PULL 11/24] meson: disable crypto tests are empty under win32, Thomas Huth, 2020/09/16
- [PULL 12/24] tests: Fixes test-replication.c on msys2/mingw., Thomas Huth, 2020/09/16
- [PULL 14/24] osdep: file locking functions are not available on Win32, Thomas Huth, 2020/09/16
- [PULL 15/24] meson: Use -b to ignore CR vs. CR-LF issues on Windows, Thomas Huth, 2020/09/16
- [PULL 13/24] tests: test-replication disable /replication/secondary/* on msys2/mingw., Thomas Huth, 2020/09/16
- [PULL 16/24] meson: remove empty else and duplicated gio deps, Thomas Huth, 2020/09/16